Siarhei Harkusha authored 1 year ago and Johannes Elmsheuser committed 1 year ago

Convert Tile run type configuration flag from string into enum

Tile run type configuration flag has been converted from string into enum.
Tile timing type configuration flag has been removed since
it can be deduced from run type.

The clients have been udpated accordingly.

Siarhei Harkusha authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Add and use Tile BS reading configuration function

New Tile BS reading configuration (CA-based) function
has been added in order to keep it in one place
because it will be modified later to read mapping
from bytestream frag ID to TileCal drawer ID from DB.
Clients has been modified to use it to read the Tile BS data.

Scott Snyder authored 1 year ago and Walter Lampl committed 1 year ago

TileCalibBlobObjs: Fix cppcheck warnings.

Explicitly qualify calls to virtual functions from constructors.

Possibility has been added to detect Tile frag ID to ROB ID mapping for FELIX automatically.
Tile frag ID for FELIX are stored in the corresponding map with common offset to avoid clash with legacy.

Siarhei Harkusha authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

TileByteStream+TileTBRec: Update unpacking Tile subfragment frag6 for FELIX data

Tile ROD Decoder has been modified to update unpacking Tile
subfragment frag6 for FELIX data with new header version.

Tile TB Dump algorithm has been modified to update dump of Tile
subfragment frag6 for FELIX data with new header version.

TileHid2RESrcID has been modified to avoid messages about
invalid FRAG IDs for FELIX data (they do not exist yet now).

Sanya Solodkov authored 1 year ago and Julien Maurer committed 1 year ago

TileCal: minor fix in BadCellsFromCOOL.py

Sanya Solodkov authored 1 year ago and Julien Maurer committed 1 year ago

TileCal: adding new options --iov and --IOV to ReadBchFromCool.py and ReadCalibFromCool.py

Sanya Solodkov authored 1 year ago and Walter Lampl committed 1 year ago

Set FRONTIER as default database server instead of ORACLE in all TileCal python scripts

Sanya Solodkov authored 1 year ago and Stefan Richter committed 1 year ago

fixing bug in TileInfoDump: RUN3 should be treated in the same way as RUN2, since MBTS and E3/E4 cabling is the same

Sanya Solodkov authored 1 year ago and Julien Maurer committed 1 year ago

updating Conditions tag in calibration jobOptions

Sanya Solodkov authored 1 year ago and Julien Maurer committed 1 year ago

updating various jobOptions in TileCalibAlgs

Rename `defaultTestFiles.RAW` into `RAW_RUN2` to make it explicit that
this is a Run-2 file.

creating new scirpt to write pulse shape to COOL

John Derek Chapman authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Replace mentions of obsolete the ATLAS-R2-2016-00-01-00 tag with ATLAS-R2-2016-01-00-01 (MC16/MC20 geometry tag)

This job option script was just forwarding the include to
CaloConditions/CaloConditions_jobOptions.py. Dropped the obsolete
script and fixed all its clients.

This is yet another step towards dropping the CaloDetMgrDetDescrCnv package

TileByteStream+TileSimAlgs+TileMonitoring+TileCalibAlgs+TileD3PDMaker: Fix clang15 warnings (ATLASRECTS-7430)

Unused variables have been removed.

Sanya Solodkov authored 2 years ago and Julien Maurer committed 2 years ago

Removing dependence on external tools installed on AFS

Siarhei Harkusha authored 2 years ago and Tadej Novak committed 2 years ago

TileCalibAlgs: Fix thread-checker warnings in Laser default calibration tool (ATLASRECTS-7308)

TileLaserDefaultCalibTool has been updated to remove static variables
to fix thread-checker warnings.

Marie-Helene Carron authored 2 years ago and Peter Berta committed 2 years ago

TileCalibAlgs: Update h3000 ntuple for Tile laser calibration runs,
4 branches added: 2 branches for the average of ratios of photodiodes (low & high gains),
2 branches for their standard deviation

Shaun Roe authored 2 years ago and Adam Edward Barton committed 2 years ago

23.0-cppcheck-TileCalibAlgs

Siarhei Harkusha authored 2 years ago and Julien Maurer committed 2 years ago

TileCalibAlgs: Add new-style configuration for Tile trigger calibration algorithm for Run3

New-style configuration has been added for Tile trigger (L1Calo) calibration algorithm for Run 3.
Test has been added for new-style configuration of Tile trigger calibration algorithm.

Siarhei Harkusha authored 2 years ago and Peter Berta committed 2 years ago

TileCalibBlobObjs: Add protection against bad value in DB (ATLASRECTS-7075)

Protection against bad values in DB has been added in TileCalibDrawerOfc
to avoid FPE if one requests OFC for bad (very big) phase.

Frank Winklmeier authored 2 years ago and Julien Maurer committed 2 years ago

TileCalorimeter: Remove redundant setting of `configurableRun3Behavior` in tests

Adam Edward Barton authored 2 years ago and Atlas Nightlybuild committed 2 years ago

Cleaning up and bug fixes in TileTriggerDefaultCalibTool

See merge request atlas/athena!53672

(cherry picked from commit 4039a4b7)

9ed72051 Cleaning up and bug fixes in TileTriggerDefaultCalibTool

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

TileCalibAlgs: Increase test timeout.

Test has been timing out in dbg builds.

New-style configurations of Tile calibration algorithms have been updated
and tests have been added for laser and CIS calibration algorithms.

Move all private headers to the src directory and add interface library.