- Jan 09, 2024
-
-
Tadej Novak authored -
Tadej Novak authored
-
- Jan 08, 2024
-
-
test_q442_mp.sh: Add --CA test_q442_mp.sh: Add --CA
-
Adjust AFP vertex reconstruction to input given by nano instead of pico seconds
-
TriggerJobOpts: propagate LAr legacy flags to ConfigFlags in runHLT_standalone Hello, When running RDOtoRDOTrigger with the legacy config, it seems that we do not set the LAr config flags correctly. In MC23, LAr flags are set by a preInclude, e.g. `--preInclude "all:Campaigns.MC23a"`, calling [Campaigns/share/MC23a.py](https://gitlab.cern.ch/atlas/athena/-/blob/main/Tools/Campaigns/share/MC23a.py), in turn calling [LArConfiguration/share/LArConfigRun3Old.py](https://gitlab.cern.ch/atlas/athena/-/blob/main/LArCalorimeter/LArConfiguration/share/LArConfigRun3Old.py). The jobproperties legacy flags are configured, but not propagated to [TriggerJobOpts/share/runHLT_standalone.py](https://gitlab.cern.ch/atlas/athena/-/blob/main/Trigger/TriggerCommon/TriggerJobOpts/share/runHLT_standalone.py) which rely on ConfigFlags. The mapping between legacy and config flags can be found in [thenaConfiguration/python/OldFlags2NewFlags.py](https://gitlab.cern.ch/atlas/athena/-/blob/main/Control/AthenaConfiguration/python/OldFlags2NewFlags.py#L109-127). After adding the mapping to runHLT_standalone, we get the following changes for MC23: * flags.LAr.ROD.nSamples is now 4 instead of 5 * flags.LAr.ROD.UseHighestGainAutoCorr is now True instead of False * flags.LAr.ROD.NumberOfCollisions is now 60 instead of 0 This bug is affecting the MC21a, MC23a and MC23c campaigns. It's impact is discussed in ATR-28590. We don't expect the counts to change in the MC CI test, because the test doesn't specify a MC campaign in the preInclude... The fix improves the agreement between CA and legacy configs (ATR-28470), the CA setup is not affected by the missing flag mapping. Cheers, Bertrand
-
- Jan 06, 2024
-
-
scott snyder authored
Pass objects by const reference, not by value.
-
- Jan 05, 2024
- Jan 04, 2024
-
-
Edmar Egidio Purcino De Souza authored
-
- Jan 03, 2024
-
-
scott snyder authored
Missing include.
-
scott snyder authored
Remove explicit copy ctors to avoid warnings about implicitly-declared assignment.
-
scott snyder authored
Remove explicit copy ctor to avoid warnings about implicitly-declared assignment.
-
scott snyder authored
Remove explicit copy ctor to avoid warnings about implicitly-declared assignment.
-
- Dec 21, 2023
-
-
L1CaloFEXByteStream: Fix cppcheck warnings. Declare crc methods to operate on unsigned quantities. Fixes warnings about undefined shifts of signed integers.
-
- Dec 20, 2023
-
-
EFTrackingEmulation: Increase test timeout. Test has been timing out in dbg builds.
-
FTF GPU: Middle SP and z0 cut, cleanup
-
main-cppcheck_suppress-TrigInDetAnalysis
-
Frank Winklmeier authoredConsistently use the `maker` property of `EmptyMenuSequenceCA` to make sure the maker alg is retrieved correctly from the CA. Resolves differences seen between running at INFO and DEBUG level. Fixes ATR-28644, ATR-28615 and ATR-28477.
-
TrigConfData, TrigConfIO: update of the L1CTPFiles structure to add CTPX switch matrix.
-
- Dec 19, 2023
-
-
Allow an ART test that creates a new directory to be run twice in the same directory
-
TrigT1CaloMonitoring: Mistimed Analysis - Phase I update
-
ZDC Trigger Simulation Patch for Run 3 Rate Estimates
-
TrigInDetValidation: drop deprecated preInclude Hello, This MR is cleaning up a leftover from !66815 . Cheers, Bertrand
-
Set scheduler defaults to match runHLT in PSC
-
TrigVrtSecInclusive: Fix cppcheck warning. Remove redundant constructor.
-
- Dec 18, 2023
-
-
Frank Winklmeier authored
Disable menu DOT files by default in unit test to save time.
-
remove commented out code I do not think `renounce` is needed in initialize since I added ftf in the chain to recon the ID vertices
-
TrigT1Interfaces: Fix cppcheck warnings. Shifting signed integers.
-
- Dec 15, 2023
-
-
TrigHLTJetHypo - add new Condition MaxCombinationCondition.h, cxx This is the first condition which breaks up an input jet vector, and acts on the pieces. The Condition is initialised with an integer value k. isSatisfied interates ove all n choose k combinations of the n incomming jets. The particular choice of n choose k which maximises a user supplied function is identified. This jet vector is passed to a Condition object which decides whether this maximum value is satisfactory. CombinationsIterator.h, cxx Forward iterator to iterate of combinations. Helper class for MaxCombinationCondition
-
Add TrigSummaryFinal in CA menu [ATR-28470]
-
Add MC newJO config diff [ATR-28500]
-
Updating monGroups, adding missing jFEX chain to Physics
-
cleanup of migration of configurePrefetchingInitialRoI to CA [ATR-28500]
-
test chains for HZy with invisible decay trigger ATR-28443
-
attempted fix for ATR-24829: created new menuEta method for TOBs to load thresholds from menus consistently created new menuEta method for TOBs to load thresholds from menus consistently with how L1Topo simulation does it
-
- Dec 14, 2023
-
-
Sort thresholdvalues by prior and etamax when querying run2 TriggerDB See merge request atlas/athena!67810
-
TrigAnalysisTest: add MC grid test comparing CA vs legacy counts Hello, Similarly to !67637 which introduced a test comparing CA vs legacy trigger counts in data, this MR introduces a test comparing CA vs legacy counts for MC. The input is a mix of ttbar, stau, and bphys samples, in order to maximise the coverage in terms of trigger menu. The test uses 8 threads, 2500 events, and runs in ~2h30. Cheers, Bertrand
-
gFEXJetAlgo: Fix blkOutAB
-
Configure ROB prefetching in newJO [ATR-28500]
-
- Dec 13, 2023
-
-
Sort thresholdvalues by prior and etamax when querying run2 TriggerDB
-
TRT high thresholds for fast-OR trigger - ATR-28372
-
