Scott Snyder authored 1 year ago and Edward Moyse committed 1 year ago

JetSelectorTools: Fix cppcheck warnings.

Pass strings by const reference, not by value.
Avoid warnings about conditions that can never be true.

Convert bitmask enums to `ATH_BITMASK` to profit from type safety and
avoid `deprecated-enum-enum-conversion` compiler warning with C++20.

Since the underlying xAOD storage is still of type `bitmask_t` a few
explicit casts are unavoidable. Changing that would be a much bigger
change.

Relates to ATLJETMET-1639.

Remove unnecessary temporary variable. Also fixes compiler error on
gcc13 ("initializer list would use explicit constructor").

Johannes Junggeburth authored 1 year ago and Julien Maurer committed 1 year ago

JetEventCleaningAlg - Clean up the pointer managerment

Johannes Junggeburth authored 1 year ago and Stefan Richter committed 1 year ago

JetEventCleaningAlg - Declare dependencies

Scott Snyder authored 1 year ago and Frank Winklmeier committed 1 year ago

JetSelectorTools: Add SuppressOutputDependnece option for EventCleaningTool.

When EventCleaningTool is used from tile monitoring, decorations are applied
to a temporary jet container that is never recorded.  In that case we should
not set output dependencies.  Add an option to control this.

See !62000.

Scott Snyder authored 1 year ago and John Kenneth Anders committed 1 year ago

JetSelectorTools: Add SuppressOutputDependnece option for EventCleaningTool.

When EventCleaningTool is used from tile monitoring, decorations are applied
to a temporary jet container that is never recorded.  In that case we should
not set output dependencies.  Add an option to control this.

See !62000.

Unused variables.

Michael Holzbock authored 2 years ago and Adam Edward Barton committed 2 years ago

Fix setup of MET configuration for PhysVal

Chris Malena Delitzsch authored 2 years ago and Edward Moyse committed 2 years ago

Small fixes / cleanup for jet and MET validation

Chris Malena Delitzsch authored 2 years ago and Edward Moyse committed 2 years ago

Removing/downgrading warnings

Chris Malena Delitzsch authored 2 years ago and Tamara Vazquez Schroeder committed 2 years ago

Manual sweep of !55324

Chris Malena Delitzsch authored 2 years ago and Frank Winklmeier committed 2 years ago

Migration of jet derivations to r22 and further fixes

Nora Emilia Pettersson authored 2 years ago and Frank Winklmeier committed 2 years ago

Clean up of CA configuration for PhysVal

Thomas Strebler authored 2 years ago and Walter Lampl committed 2 years ago

Added CA config for MET PhysValMonitoring

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

JetSelectorTools: Fix thread-safety checker warnings.

Calling via non-const pointer from const method.

It is a widespread and reasonable, but incorrect, pattern to assume that if a handle(key) is not used then it should not be initialized.
In fact, this leaves the data dependency active in the scheduler, and no error will be thrown if the handle is never accessed.
Instead, the handle should be initialized(false) - this MR makes the change

Unchecked StatusCode.

TAG files are no longer being produced. Delete this obsolete TAG
maker and code referencing it.