Oliver Majersky authored 1 year ago and Tadej Novak committed 1 year ago

Revert "Remove FTAG selectionNmaes that are actually never used."

This reverts commit 436ed695ee7b5bd6eca92350ab934a44107c82c2.

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: bugfix for PerEventSFBlock

Baptiste Ravina authored 1 year ago and Tadej Novak committed 1 year ago

CPAlgorithms: refactor the object cutflow

Scott Snyder authored 1 year ago and Tadej Novak committed 1 year ago

AthContainers: Update copy/copyForOutput to work on AuxVectorData.
    
Update the copy/copyForOutput methods of IAuxTypeVectorFactory / AuxTypeRegistry
to take AuxVectorData instances rather than bare pointers.
Remove the corresponding static methods from AuxTypeVector.

Refactoring to make possible dependencies between auxiliary variables,
as would be used to support packed links / jagged vectors.
Also alter them to operate on ranges, rather than a single element.

Revert "Merge branch 'bugfix_objectcutflow' into 'main'"

This reverts merge request !68554

Baptiste Ravina authored 1 year ago and Tadej Novak committed 1 year ago

CPAlgorithms: refactor the object cutflow

The main usage here is that if OR is run before MET we don't want to use the OR selections with MET.  A similar issue is expected to come up with fakes/fakeable objects, i.e. some specific baseline cuts should not be applied (in fact they are inverted), but only for very specific users.

The mechanism chosen here is to mark the cuts when they are registered and then exclude by name when requesting the selection.

Baptiste Ravina authored 1 year ago and Adam Edward Barton committed 1 year ago

CPAlgorithms: smarter systematic printouts

Oliver Majersky authored 1 year ago and Johannes Elmsheuser committed 1 year ago

Rework interface for GRL and PRW block configuration in CP algos

Thomas Strebler authored 1 year ago and Walter Lampl committed 1 year ago

Added forceFullSimConfig for EGamma analysis configs for testing (ATLASG-2661)

Guglielmo Frattari authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Addition of PRW to IDPVM

Joseph Earl Lambert authored 1 year ago and Frank Winklmeier committed 1 year ago

Default blocks are added by default. PRW parameters are obtained from ConfigAccumulator.

Add autoconfigFlags as an attribute to the ConfigAccumulator so information can be
obtained in other blocks.

Update the PileupReweighting block so that campaign, input files, and useDefaultConfig
can be obtained from autoconfigFlags. The wrapper function that handeled this before has
been removed.

addDefaultAlgs function is now part of the ConfigFactory class and is called
automatically when initializing an object instance. Default parameters are now
obtained from ConfigAccumulator except for noSystematics flag so that this can
be changed from the command line if not specified directly.

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: improve the IFFLeptonDecorationBlock

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: config block for IFF classifier

Baptiste Ravina authored 1 year ago and Walter Lampl committed 1 year ago

CPAlgorithms: expose the useClusterEta property of the PtEtaSelection tool

Baptiste Ravina authored 1 year ago and Walter Lampl committed 1 year ago

CPAlgorithms: expose all aspects of OR in the config block

Baptiste Ravina authored 1 year ago and Walter Lampl committed 1 year ago

Remove HI legacy menu sequence definition

Remove HI legacy menu sequence definition

Baptiste Ravina authored 1 year ago and Tadej Novak committed 1 year ago

CPAlgorithms: more user-side improvements

Baptiste Ravina authored 1 year ago and Tadej Novak committed 1 year ago

CPAlgorithms: allow failed branch filters on data

A fairly long-standing feature request that allows to enable and disable
individual branches in the output n-tuple.  As a bit of a silly example
of how this can work:
```
configSeq.setOptionValue ('.commands', ['disable jet_ftag.*', 'enable jet_ftag_legacy_.*'])
```

The basic idea is that every branch gets/has a flag indicating whether
it is enabled in the output or not.  This allows to disable a big chunk
of them and then re-enable a subset, but it also allows to add some
expert-level branches that are disabled by default.

The way this works it (should) turn off all but the nominal for the main overlap removal algorithm, and then schedules extra algorithms to copy over the decision from the nominal to all shallow copies, so that it can be used for preselections in other algorithms (if desired).

I did test that it runs and defined some test cases, but I didn't test at all that it does anything meaningful or correct.  I leave that to physics validation.

Baptiste Ravina authored 1 year ago and Johannes Elmsheuser committed 1 year ago

CPAlgorithms: add the option to print out the list of systematics to the output

Scott Snyder authored 1 year ago and Johannes Elmsheuser committed 1 year ago

AthContainersInterfaces: Add auxid to create methods of IAuxTypeVectorFactory.

Pass the auxid to the create methods of IAuxTypeVectorFactory.
This allows the vector instances to know which variable they are
representing, which will be needed for packed links and jagged arrays.

Baptiste Ravina authored 1 year ago and Johannes Elmsheuser committed 1 year ago

CPAlgorithms: user-side improvements to the config blocks

Baptiste Ravina authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

CPAlgorithms: change 'mc' to 'fullsim' in the config blocks metadata handling

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: prevent systematics from running on data!

This switches to the new configuration mechanism.  I had to add a
number of options to the blocks to make this happen.

Oliver Majersky authored 1 year ago and Frank Winklmeier committed 1 year ago

Add protection for running PRW CP algo config block on data

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: add flag autoconfiguration to ConfigAccumulator

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: various minor improvements for more user-friendly experience

Baptiste Ravina authored 1 year ago and Edward Moyse committed 1 year ago

CPAlgorithms: enable systematics filtering in config blocks

Baptiste Ravina authored 1 year ago and Edward Moyse committed 1 year ago

CPAlgorithms: common bootstrapping algorithm

Matthew Kenneth Maroun authored 1 year ago and Johannes Elmsheuser committed 1 year ago

Container Name Reconfigure for OverlapAnalysisConfig

Baptiste Ravina authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

CP Algorithms: event cut flow

Teng Jian Khoo authored 1 year ago and Adam Edward Barton committed 1 year ago

Use numerical values in invertFlags list to avoid AnalysisBase parse errors

The primary thing this does is to introduce a SelectionNameSvc that
tracks the name of all the selection bits as reported by the various
selection tools, allowing to give much better labels for the
individual bins in the selection.  In addition this means I no longer
need to track the bits for each selection mask, as they get
automatically tracked.

I also added a configuration block for the cut flows (there wasn't one
yet), that allows to neatly add the cut flows when added.

The one breaking change is that this now requires a SelectionNameSvc
to get created.  I hope this doesn't cause too many issues.  In order
to minimize the effect of such changes in the future I introduced a
CommonServicesBlock (and corresponding sequence), to which I can add
more services as needed.