Zach Marshall authored 1 year ago and Walter Lampl committed 1 year ago

Updates to DumpEventDataToJSONConfig for PHYSLITE

Adding a feature to the DumpEventDataToJSONConfig configuration function
that checks if we are running on PHYSLITE (based on something that I
believe is trustworthy) and then configures the input collections
accordingly. At the moment there are no track particles that can be
output, which isn't great, but the rest seems to work reasonably well.

There were a few collections that appear to not exist in the C++ code,
so I've removed the setting of those collection names (it causes the
function to crash out of the box).

Fixing a typo in a comment as well.

Modernize loops in MCTruthClassifier

See merge request atlas/athena!69717

Andrii Verbytskyi authored 1 year ago and Walter Lampl committed 1 year ago

Modernize loops in MCTruthClassifier

BPHY13,BPHY23 updates and adding BPHY25

See merge request atlas/athena!69731

Xin Chen authored 1 year ago and Walter Lampl committed 1 year ago

BPHY13,BPHY23 updates and adding BPHY25

Remove unused algorithm

See merge request atlas/athena!69768

Carlo Varni authored 1 year ago and Walter Lampl committed 1 year ago

Remove unused algorithm

MuonSelectorTools: Fix FPEs in clang build.

See merge request atlas/athena!69748

Scott Snyder authored 1 year ago and Walter Lampl committed 1 year ago

MuonSelectorTools: Fix FPEs in clang build.

Enable trapping FPEs in MuonSelectionTool::qOverPsignificance
to avoid spurious FPEs in the clang build.
Fixes test failures in AnalysisAlgorithmsConfig in the clang build.

Use set MotherProperties to avoid code duplication in MCTruthClassifier

See merge request atlas/athena!69725

Andrii Verbytskyi authored 1 year ago and Walter Lampl committed 1 year ago

Use set MotherProperties to avoid code duplication in MCTruthClassifier

Move more functions from MCTruthClassifier to TruthUtils

See merge request atlas/athena!69099

Andrii Verbytskyi authored 1 year ago and Walter Lampl committed 1 year ago

Move more functions from MCTruthClassifier to TruthUtils

MuonPhaseII -- Use GeoModelHelpers to share MdtTube layers and to remove shared code

See merge request atlas/athena!69760

Johannes Junggeburth authored 1 year ago and Walter Lampl committed 1 year ago

MuonPhaseII -- Use GeoModelHelpers to share MdtTube layers and to remove shared code

Including two tests for HLTCalo in GPU running

See merge request atlas/athena!69772

Denis Oliveira Damazio authored 1 year ago and Walter Lampl committed 1 year ago

Including two tests for HLTCalo in GPU running

TauAnalysisTools: change default truth jet container in tau truth matching

See merge request atlas/athena!69765

Bertrand Martin Dit Latour authored 1 year ago and Walter Lampl committed 1 year ago

TauAnalysisTools: change default truth jet container in tau truth matching

Hello,

This MR is changing the default truth jet container used for tau truth matching from `AntiKt4TruthJets` to `AntiKt4TruthDressedWZJets`, as the latter is much more widely used.
It's a follow-up of !68328 .
This will hopefully fix the AnalysisAlgorithmsConfig ctest failure.
Not sure what the test was doing so far... it was also using the wrong container, but maybe the use of data handles creates a louder error.

Cheers,
Bertrand

Andrej Saibel corrections to SFGen Athena interface

See merge request atlas/athena!69581

Lorenzo Primomo authored 1 year ago and Walter Lampl committed 1 year ago

Andrej Saibel corrections to SFGen Athena interface

main-coverity-CoolConvUtilities

See merge request atlas/athena!69764

Shaun Roe authored 1 year ago and Walter Lampl committed 1 year ago

main-coverity-CoolConvUtilities

RootUtils: Update reference to libcppyy for root master.

See merge request atlas/athena!69750

Scott Snyder authored 1 year ago and Walter Lampl committed 1 year ago

RootUtils: Update reference to libcppyy for root master.

The name of the cppyy library was changed to include the python version
as part of the python 3 migration.  This change is now reverted in 
root master.  In the find_package, list cppyy both with and without
the python version so that we can build against both current and master
versions of root.

MuonSpacePointFormation - Fix centos 7 compilation and minor tweaks

See merge request atlas/athena!69761

Johannes Junggeburth authored 1 year ago and Walter Lampl committed 1 year ago

MuonSpacePointFormation - Fix centos 7 compilation and minor tweaks

IOVSvc: Fix cppcheck warning.

See merge request atlas/athena!69757

Scott Snyder authored 1 year ago and Walter Lampl committed 1 year ago

IOVSvc: Fix cppcheck warning.

Initialize string member in an initialization list.

Fix transform of the tube layers of the mdts

See merge request atlas/athena!69730

Dimitra Amperiadou authored 1 year ago and Walter Lampl committed 1 year ago

Fix transform of the tube layers of the mdts

Merge the ID & MS alignment Geometry context alg

See merge request atlas/athena!69718

Johannes Junggeburth authored 1 year ago and Walter Lampl committed 1 year ago

Merge the ID & MS alignment Geometry context alg

Toggle tracking geo svc

Apply 1 suggestion(s) to 1 file(s)

Print statement

ISF_FastCaloSimEvent: Fix placement of using declaration.

See merge request atlas/athena!69754

Scott Snyder authored 1 year ago and Walter Lampl committed 1 year ago

ISF_FastCaloSimEvent: Fix placement of using declaration.

Don't put a using declaration in the global namespace in a header.

RDBAccessSvc: Fix cppcheck warnings.

See merge request atlas/athena!69758

Scott Snyder authored 1 year ago and Walter Lampl committed 1 year ago

RDBAccessSvc: Fix cppcheck warnings.

Pass strings by const reference, not by value.
Copying value in range-for.

IOVDbFolder: introduced new private function fetchCrestObjects()

See merge request atlas/athena!69749

FPGATrackSimConfTools: Fix typo in error message.

See merge request atlas/athena!69752

Scott Snyder authored 1 year ago and Walter Lampl committed 1 year ago

FPGATrackSimConfTools: Fix typo in error message.

Fix typo in error message.