Maciej Pawel Szymanski authored 1 year ago and Frank Winklmeier committed 1 year ago

Improve documentation and log messages of metadata-related components

Print the unit test `diff` to stdout instead of a file to make it
visible in the main test output (and the NICOS web pages). Also change
to unified diff format to make the file names visible.

Maciej Pawel Szymanski authored 1 year ago and Julien Maurer committed 1 year ago

Check if LumiBlock containers exist before recording

Maciej Pawel Szymanski authored 2 years ago and Edward Moyse committed 2 years ago

OutputStreamConfig+LumiBlockComps: migrate configuration of CreateLumiBlockCollectionFromFile to CA

Rename `defaultTestFiles.RAW` into `RAW_RUN2` to make it explicit that
this is a Run-2 file.

Andrii Verbytskyi authored 2 years ago and Frank Winklmeier committed 2 years ago

cppcheck:Function parameters that should be passed by const reference

Use `CAtoGlobalWrapper` to merge CA-fragments to old job options.

Tadej Novak authored 2 years ago and Atlas Nightlybuild committed 2 years ago

use AccumulatorCache for LuminosityCondAlgCfg

See merge request atlas/athena!58200

(cherry picked from commit db5cd85d)

baf2ab10 use AccumulatorCache for LuminosityCondAlgCfg

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

LumiBlockComps: Protect against missing bunch group data.

Don't crash in BunchCrossingCondAlg if bunch group data are missing.

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

LumiBlockComps: Remove reference to EventInfo.

Remove reference to old EventInfo package.

Peter Onyisi authored 2 years ago and Tadej Novak committed 2 years ago

BunchCrossingCondAlg: Fix for ATR-26014 (Version 2)

Scott Snyder authored 2 years ago and Adam Edward Barton committed 2 years ago

LumiBlockComps: Fix potential memory leaks.

Fix potential memory leaks.

Peter Onyisi authored 2 years ago and Walter Lampl committed 2 years ago

Update default bunch crossing info source

Scott Snyder authored 2 years ago and Walter Lampl committed 2 years ago

LumiBlockTPCnv: Fix thread-safety warnings.

Fix thread-safety checker warnings when warnings on calls to unchecked functions
are enabled.

Adam Edward Barton authored 2 years ago and Atlas Nightlybuild committed 2 years ago

GoodRunsLists: thread-safety fixes and code cleanup

See merge request atlas/athena!54666

(cherry picked from commit 19f72a38)

7cb8631d GoodRunsLists: thread-safety fixes and code cleanup
91844e64 LumiCalc: annotate thread-unsafe code

The BunchCrossingCondData depends on conditions data which uses both run/LB
and time stamp based IOVs. Thus the container has to be declared as mixed.

Also ensure that the bunch crossing conditions data is added with valid
timestamp and run/lumi ranges. Otherwise it cannot be added to the mixed
conditions container.

Annotate code that uses thread-unsafe classes from GoodRunsLists.

Christos Anastopoulos authored 2 years ago and Peter Berta committed 2 years ago

CondAlg non-Reentrant part VII

Walter Lampl authored 2 years ago and Andrea Coccaro committed 2 years ago

CondCont.cxx: Remove spurious cout

CondCont.cxx: Remove spurious cout

Frank Winklmeier authored 2 years ago and Julien Maurer committed 2 years ago

Remove loadAllDynamicFlags from unit tests

The use of `loadAllDynamicFlags` is not needed and can cause unnecessary
flags loading (and errors) in projects that do not include all packages.

Since as it turns out, it doesn't actually depend on it (anymore).

Frank Winklmeier authored 2 years ago and Julien Maurer committed 2 years ago

Remove rendundant setting of congfigurableRun3Behavior in tests

Walter Lampl authored 2 years ago and Adam Edward Barton committed 2 years ago

LumiBlockComps: use addDependency

Missing dependency on LumiBlockData.

    
Update reference files for rounding changes in printing.
Resolves test failures on aarch64.