Jahred Adelman authored 10 months ago and Tadej Novak committed 10 months ago

Simple Additional Monitoring for FPGATrackSim

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimHough: Fix cppcheck 2.14 warnings.

Copying values in range-for.
Prefer returning const references to members rather than copies.
Prefer to pass strings/containers by const reference rather than value.
Redundant map lookup.

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimBankGen: Fix property initialization.

Fix typo in initialization of Gaudi property.

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimHough: Fix signed/unsigned comparison warnings.

Fix signed/unsigned comparison warnings for Gaudi properties.

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimMaps: Fix cppcheck warnings.

Out-of-bounds array accesses.
Redundant map lookup.
Copying values in range-for.

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimAlgorithms: Fix cppcheck 2.14 warnings.

Copying values in range-for.
Potential use of invalidated iterators.
Prefer range-for.
sprintf format/argument match.  sprintf buffer size.
Pass objects by const reference, not by value.
Prefer returning const references to members rather than copies.

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimBanks: Fix cppcheck 2.14 warnings.

Delete copy/assignment from class that manages memory.
Unknown macro.
Prefer returning const references to members rather than copies.
Prefer to pass strings/containers by const reference rather than value.

Copying values in range-for.
Prefer preincrement for iterator classes.

Copying value in range-for.

Ioannis Maznas authored 10 months ago and Walter Lampl committed 10 months ago

EFTracking: FPGATrackSim: Update unit tests and fix bank generation

Ioannis Maznas authored 11 months ago and Walter Lampl committed 11 months ago

EFTracking : FPGATrackSim : Enable truth info for RDO analysis and add output check

Shaun Roe authored 11 months ago and Walter Lampl committed 11 months ago

main-cppcheck-FPGATrackSimAlgorithms

FPGATrackSimMaps: fix flake8 warnings and errors

Ioannis Maznas authored 11 months ago and Frank Winklmeier committed 11 months ago

FPGATrackSimBanks: Clean up of legacy configs

Shaun Roe authored 11 months ago and Frank Winklmeier committed 11 months ago

main-cppcheck-FPGATrackSimAlgorithms

- ActsDataPreparation/PixelClusteringTool: Unused function
- ActsEventCnv/ActsToTrkConvertorAlg: Unused lambda capture
- ActsTrackReconstruction/TrackFindingAlg: Reference cannot be bound to dereferenced null
pointer in well-defined C++ code
- FPGATrackSimHough/FPGATrackSimHough1DShiftTool: Unused static functions
- ISF_Event/ISFTruthIncident: Delete called on non-final class that has virtual functions
but non-virtual destructor

Jahred Adelman authored 11 months ago and Adam Edward Barton committed 11 months ago

Updates to eta pattern filter and 1D Hough

Ioannis Maznas authored 11 months ago and Adam Edward Barton committed 11 months ago

Fix unit tests after legacy config cleanup

Thomas Strebler authored 11 months ago and Petar Bokan committed 11 months ago

Clean up legacy EFTracking FPGA configs

Jahred Adelman authored 11 months ago and Adam Edward Barton committed 11 months ago

EFTracking/FPGATrackSim: port spacepoint-based fitting, updated Hough transforms, related changes from HTTSim (Part 1)

FPGATrackSim: make track fit constants spacepoint aware

Ported over from HTTSim. Since a spacepoint is formed from two strip hits
from two layers, we keep two copies for bookkeeping purposes. At the moment
that then means that in the fit, there are two versions of the spacepoint's
phi coordinate-- and the z/eta coordinate is never used. This commit changes
that so we dynamically select whether the spacepoint's coordinate is phi
or z/eta based on whether it is in an inner or outer strip layer.

This nicely avoids having to remove duplicate spacepoints, and also avoids
having to rework a fundamental assumption of the code, which is that strip
hits are only ever "one" dimension. Since we don't remove duplicates or
change the number of layers it also makes it easy to mix and match strip
hits with spacepoints; a track could (conceivably) have two strip hits
in two layers that are one spacepoint OR two strip hits from which a
spacepoint couldn't be formed.

Ioannis Maznas authored 11 months ago and Tadej Novak committed 11 months ago

Restore unit tests for FPGATrackSim

Fix typo in test name.

In main, each row is considered a separate etaModule (and gets its
own hashcode).  Previously, etaModules were divided into 2 or 4 rows.
Remove the temporary fix that was put in earlier to deal with this.
Fixes out-of-bounds array reads that were causing ubsan warnings
in the FPGATrackSimConfTools test.

Jahred Adelman authored 1 year ago and Edward Moyse committed 1 year ago

remove old files in FPGATrackSim

Tomasz Bold authored 1 year ago and Edward Moyse committed 1 year ago

Fix FPGASim workflow test to use input RDO from CVMFS

Jahred Adelman authored 1 year ago and Frank Winklmeier committed 1 year ago

Add unit test for FPGATrackSim and fix workflow for analysis on wrapper file