ZdcAnalysis+ZdcRec: Use Accessor, etc instead of auxdata().

See merge request !71359

EFTrackingEmulation: cmake fixes

See merge request !71358

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

EFTrackingEmulation: cmake fixes

Don't link against a TPCnv library.
Don't declare directories as sources.

MuonGeoModelR4 - Convert new sTgc readout elements into their legacy version

See merge request atlas/athena!71219

Johannes Junggeburth authored 10 months ago and Tadej Novak committed 10 months ago

MuonGeoModelR4 - Convert new sTgc readout elements into their legacy version

DataModelRunTests: Fix test failure in LTO build.

See merge request atlas/athena!71357

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

DataModelRunTests: Fix test failure in LTO build.

Work around library loading order issue in LTO build.

ISF_FastCaloSimParametrization: Fix ODR violation in debug build.

See merge request !71355

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

ISF_FastCaloSimParametrization: Fix ODR violation in debug build.

When we force code to be compiled with optimization in the debug build,
we also need to make sure that NDEBUG remains undefined.
Otherwise, we can be generating inconsistent code for Trk::ObjectCounter.
This was causing a warning when linking AtlasGeant4 in the debug build.

MuonEventTPCnv: Update dummy det description.

See merge request !71354

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

MuonEventTPCnv: Update dummy det description.

Update the dummy detector description used for unit tests.
sTGC will trip an assertion failure if it doesn't see four layers.
Fixes test failures in the debug build.

Make all GPU tests single threaded, remove statement about running in 24.0

See merge request !71347

Stewart Martin-Haugh authored 10 months ago and Tadej Novak committed 10 months ago

Make all GPU tests single threaded, remove statement about running in 24.0

SystemExit with string causes cryptic error -- Change to ValueError

See merge request !71346

Beojan Stanislaus authored 10 months ago and Tadej Novak committed 10 months ago

SystemExit with string causes cryptic error -- Change to ValueError

PyUtils: delete unused filter-and-merge-d3pd

See merge request !71344

PMGSystematicsTools: do not install scripts as python modules

See merge request atlas/athena!71343

MagicNumbers.h: directly use BarcodeBased versions of helper functions

See merge request !71341

John Derek Chapman authored 10 months ago and Tadej Novak committed 10 months ago

MagicNumbers.h: directly use BarcodeBased versions of helper functions when operating on integer barcode values

ROOT error handling: Explicitly load the atomic variable for the original handler

See merge request !71328

Replace auxdata, etc. with Accessor classes.
Moving to deprecate these usages in the Athena build.

Replace auxdata, etc. with Accessor classes.
Moving to deprecate these usages in the Athena build.

2024-05-13: merge of 24.0 into main

See merge request atlas/athena!71326

Delete unused (and broken) `filter-and-merge-d3pd` script.

Initial sequences suport for CA-based event generation

See merge request atlas/athena!70700

TrigTransform: fix failure when running in CA-mode

Closes ATR-29357

See merge request atlas/athena!71330

Add phi extension to Phase-2 Muon pattern recognition and clean up / document existing steps

See merge request atlas/athena!71287

Maximilian Emanuel Goblirsch-Kolb authored 10 months ago and Tadej Novak committed 10 months ago

Add phi extension to Phase-2 Muon pattern recognition and clean up / document existing steps

Simplification for truth record functions

See merge request atlas/athena!71049

Andrii Verbytskyi authored 10 months ago and Tadej Novak committed 10 months ago

Simplification for truth record functions

After !71207, the transform code no longer appends an explicit `--CA` to
the athena command line.

Closes ATR-29357.

xAODCore+xAODTrigger: New method for registering auxiliary variables.

See merge request atlas/athena!71043

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

xAODCore: New method for registering auxiliary variables.

Introduce new macro AUXVAR_DECL to declare an auxiliary variable.
Can use like:

class FooAuxContainer : public AuxContainerBase
{
...
private:
  AUXVAR_DECL (int, intVar);

Nothing is required in the constructor.

An alternate allocator for the vector (if it exists) may be passed
as an extra argument:

  AUXVAR_DECL (int, intVar, std::pmr::polymorphic_allocator);

In this case, the allocator for this variable will be initialized
with the memory resource passed to the AuxContainerBase constructor.

This allows specifying the container type to use in one place.
This style of declaration will also be needed for linked variables,
such as packed links and jagged vectors.

MuonReadoutGeometryR4: Speed up MdtTubeLayer::getTubeNode().

See merge request atlas/athena!71295

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

MuonReadoutGeometryR4: Speed up MdtTubeLayer::getTubeNode().

This was using getChildVol.  However, that keeps track of the transform
to each child, even though that is not actually used.
This is slow, especially in debug builds where Eigen operations
tend to be expensive.

Instead, use GeoVisitVolumes to iterate over children without calculating
the transforms.