Sagar Addepalli authored 2 years ago and Tadej Novak committed 2 years ago

Fix trackParticleMerger property spelling

James Catmore authored 2 years ago and Tadej Novak committed 2 years ago

Consistently use CommonAugmentation instead of DerivationKernel for common DAOD augmentations

We noticed during the CA migration of the derivation framework that the cut flow book-keepers were registering cuts from a variety of algorithms that were not involved in event selection. This was because in a few places DerivationKernel (an AthFilterAlgorithm with setFilterPassed explicitly set) was used in writing common augmentations, whereas the correct thing to do is to use CommonAugmentation, which does the same job but doesn't register a cut. This MR implements that correction. Although this issue impacts both the legacy configuration and the CA version, the fix is only applied in the CA.

Johannes Junggeburth authored 2 years ago and Tadej Novak committed 2 years ago

Four-lepton vertex fit in the derivation step

Sagar Addepalli authored 2 years ago and Tadej Novak committed 2 years ago

Changes to LLP1 for dHNL analysis

Remove doubly written track variables

Minor fixes to track particle merger

Fix some track parameter variables

Remove params now :(

Add back some GSF vars

Remove commented out lines

calo iso for LRT leptons

adding missing iso and other information for LRT leptons

simplify muon CA setup

clean up calo iso

remove un-needed jet inputs for muons

one more cleanup

Fix repititions

Change spelling back into the incorrect one :(

Fix MuonSegments to CombinedMuonTrackParticles

Change LRT trigger matching tool to be private tool of LLP1

Turn on TurnOffMomCorr=true in MuonSelectionTool as this is an analysis level correction.  Need to run on AODs from newer releases

Fix electron ID used in overlap removal

Add comment for future reference

Remove electrons that fail ID in OR from merged collection

fix typo

Remove old comment

Add MS containers

Remove redundant import

Fix indentation and property confusion

Update to new property style

Use `AthMessaging` for logging and cleanup the `BPHYS_CHECK` macro. The
latter used the existence of `ATH_MSG_WARNING` as a means to decide if
the message logging is available. That's extremely fragile as minor
changes to includes can make the code fail to compile (as seen in
!55931).

Reworks/refactors V0Finder to reuse decorator code
Fix a bug in BPHY10 (ATLBPHYS-235) - The change to JpsiPlusV0Cascade.cxx
Fixes V0Finder erroneously decorating the primary vertices (ATLASRECTS-7186)
Clean up old dependencies
Use xAOD::EventInfo instead of BeamSpotConditions

Cristiano Alpigiani authored 2 years ago and Tadej Novak committed 2 years ago

Updating some derivation ARTs

This MR updates the preExec of some ART which are still missing the additional flag 'DetFlags.detdescr.Muon_setOn();'. Some train tests have beem moved to the right folder (not sure why the ended up in the EGAM one). I took this opportunity to activate the sharedWriter tests in master/AthDerivation (currently they are only running in master/Athena). master/AthDerivation seems to be running fine (except for a couple of failures we need to follow up), so it may be fully operational soon (after that master/Athena will all be disabled).

Tadej Novak authored 2 years ago and Atlas Nightlybuild committed 2 years ago

Derivation_tf does not have a legacy skeleton

See merge request atlas/athena!55914

(cherry picked from commit c62e792e)

5d0d55dc Derivation_tf does not have a legacy skeleton

Ricardo Barrue authored 2 years ago and Tadej Novak committed 2 years ago

Adding HLT jet information to JETM1; fixing typo in StaticNamesAndTypes

Dan Guest authored 2 years ago and Benjamin Philip Kerridge committed 2 years ago

Moved the lines of b-tagging code that replace or append strings to the top level function BTagAlgsCfg

Moved the lines of b-tagging code that replace or append strings to the top level function BTagAlgsCfg

Miriam Watson authored 2 years ago and Peter Berta committed 2 years ago

Add Phase 1 FEX containers to L1Calo derivations

Roshan Joshi authored 2 years ago and Adam Edward Barton committed 2 years ago

Moved the lines of b-tagging code that replace or append strings to the top level function BTagAlgsCfg

Moved the lines of b-tagging code that replace or append strings to the top level function BTagAlgsCfg

Atlas Nightlybuild authored 2 years ago and Julien Maurer committed 2 years ago

DerivationFrameworkConfiguration+RecJobTransforms: Set Loop Manager EventPrintoutInterval to 100 events in CA-based AODMerge and Derivations

Merge branch 'master-eventprintoutlvl' into 'master'

DerivationFrameworkConfiguration+RecJobTransforms: Set Loop Manager EventPrintoutInterval to 100 events in CA-based AODMerge and Derivations

See merge request atlas/athena!55613

(cherry picked from commit d8d47324)

b4c2df1e Set Loop Manager EventPrintoutInterval to 100 events in CA-based AODMerge and Derivations
5c8bef7e Introduce EventPrintoutInterval to AthMpEvtLoopMgr and pass this along to AthenaEventLoopMgr

James Catmore authored 2 years ago and Adam Edward Barton committed 2 years ago

Adding new flavour tagging and muon variables to PHYSLITE

This MR adds the new DL1dv00 and DL1dv01 to PHYSLITE, along with the CaloMuonScore variable. All are needed by standard analysis. Changes have been applied to the legacy and new configuration files for debugging purposes.

Shaun Roe authored 2 years ago and Adam Edward Barton committed 2 years ago

23.0-cleanup-TrkVKalVrtFitter

Ligang Xia authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

add a few muon variables and muon tracks thinning

John Derek Chapman authored 2 years ago and Julien Maurer committed 2 years ago

xAODTruthCnv configuration module renaming

Jonathan Long authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

New electron CP package for LRT; convert merging tools to CP

Initial thread-checker fixes:
- remove use of `DataHandle`
- use `static const` initialization
- use atomic counters

Chris Malena Delitzsch authored 2 years ago and Tamara Vazquez Schroeder committed 2 years ago

Manual sweep of !55324

James Catmore authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Adding passThrough option to CA version of the derivation framework

This MR equips the component-accumulator version of the derivation framework with the passThrough option. When used it disables all skimming and writes every event. It is needed for certain MC studies.

Usage is

```
Derivation_tf.py ... --passThrough True
```

Use `ConstDataVector` for filtering.

Adam Edward Barton authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

BPHY Derivations CA Migration Part 1: A New Hope

Thomas Strebler authored 2 years ago and John Kenneth Anders committed 2 years ago

CA-tracking configuration per package: TrkVertexFitterUtils + xAODTrackingCnv

Dan Guest authored 2 years ago and Julien Maurer committed 2 years ago

Politely tell JetFitterNN to go away

Anthony Morley authored 2 years ago and Frank Winklmeier committed 2 years ago

Use correct PV collection in Btagging for H1D1

Dominique Trischuk authored 2 years ago and Frank Winklmeier committed 2 years ago

Add VBF triggers to LLP1 trigger skimming