Baptiste Ravina authored 10 months ago and Johannes Elmsheuser committed 10 months ago

CPAlgorithms: Fix trigger matching selection name

2024-05-08: merge of 24.0 into main

Closes ATR-29338

See merge request atlas/athena!71237

LArCalibUtils+TilePulseSimulator: Fix cppcheck warning.

See merge request atlas/athena!71232

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

LArCalibUtils: Fix cppcheck warning.

Pass container by const reference, not by value.

ISF_FastCaloSimParametrization: Fix cppcheck 2.14 warnings.

See merge request !71231

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

ISF_FastCaloSimParametrization: Fix cppcheck 2.14 warnings.

Prefer returning const references to members rather than copies.

G4UserActions: Fix cppcheck warnings.

See merge request !71230

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

G4UserActions: Fix cppcheck warning.

Pass container by const reference, not by value.
Delete copy/assignment for class managing memory.

MuonGeoModelTestR4: Fix cppcheck warnings.

See merge request !71229

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

MuonGeoModelTestR4: Fix cppcheck warnings.

Use string::starts_with rather than string::find.

DataModelRunTests: remove obsolete --CA from athena shebang

See merge request !71209

Frank Winklmeier authored 10 months ago and Johannes Elmsheuser committed 10 months ago

DataModelRunTests: remove obsolete --CA from athena shebang

Integration of NewVrtSecInclusiveTool in FTAG2 for the tool calibration

See merge request !71185

Beatrice Cervato authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Integration of NewVrtSecInclusiveTool in FTAG2 for the tool calibration

Rewrite ACTS space point formation job option

See merge request !71155

Carlo Varni authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Rewrite ACTS space point formation job option

ITk pixel bytestream encoding

See merge request !71106

Sebastien Roy-Garand authored 10 months ago and Johannes Elmsheuser committed 10 months ago

ITk pixel bytestream encoding

new p3 versions for new Hepmc particle links

See merge request !70947

Philip Clark authored 10 months ago and Johannes Elmsheuser committed 10 months ago

added missing p3 versions to the TPCnv.cxx file, set them to old rather than current, but perhaps new makes more sense

PyJobTransforms: drop --CA option when launching athena

See merge request !71207

Frank Winklmeier authored 10 months ago and Johannes Elmsheuser committed 10 months ago

PyJobTransforms: drop --CA option when launching athena

`athena.py` now discovers CA/legacy mode automatically based on the
shebang in the job options.

Fixed clang warnings

See merge request !71234

Vakhtang Tsulaia authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Fixed clang warnings

Removed unused private data members. Plus minor code cleanup.
Affected packages
- `ForwardDetectors/ZDC/ZdcAnalysis`
- `LArCalorimeter/LArCOOLConditions`

TRT_GeoModel: code cleanup and optimization

See merge request !71233

Vakhtang Tsulaia authored 10 months ago and Johannes Elmsheuser committed 10 months ago

TRT_GeoModel: code cleanup and optimization

Removed code duplicates, eliminated redundant code fragments, improved readability

IsolationTool+JetRecTools: Use Accessor, etc instead of auxdata().

See merge request !71228

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

IsolationTool: Use Accessor, etc instead of auxdata().

Replace auxdata, etc. with Accessor classes.
Moving to deprecate these usages in the Athena build.

InDetIncSecVxFinderTool+InDetVKalVxInJetTool: Use Accessor, etc instead of auxdata().

See merge request !71227

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

InDetIncSecVxFinderTool: Use Accessor, etc instead of auxdata().

Replace auxdata, etc. with Accessor classes.
Moving to deprecate these usages in the Athena build.

TrkVertexFitters+TrkVKalVrtFitter: Use Accessor, etc instead of auxdata().

See merge request !71226

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

TrkVertexFitters: Use Accessor, etc instead of auxdata().

Replace auxdata, etc. with Accessor classes.
Moving to deprecate these usages in the Athena build.

Update epos_crmc.param to use Breit-Wigner distribution for the decayed resonance masses

See merge request atlas/athena!71236

Andrii Verbytskyi authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Update epos_crmc.param to use Breit-Wigner distribution for the decayed resonance masses

MuonReadoutGeometryR4: Speed up handling of tube transforms.

See merge request atlas/athena!71223

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

MuonReadoutGeometryR4: Speed up handling of tube transforms.

Calling toTubeFrame is expensive, since it needs to walk over all children
until it gets to the desired value.  Hence, calling toTubeFrame from within
a loop over tubes is an N^2 operation.  Further, MdtReadoutElement::initElement()
was calling toTubeFrame multiple times for each tube.
This is especially painful in a debug build, where Eigen matrix operations
are very slow.

Speed up by using GeoVolumeCursor to change from the nested O(N^2) iteration
to a single O(N) iteration, and only evaluate the transform once per tube.

Also fix a logic error the prevented the layer-to-layer pitch test from
executing.

CxxUtils: Add some preprocessor utils.

See merge request atlas/athena!71221

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

CxxUtils: Add some preprocessor utils.

Add pputils.h, which defines some helper macros for extracting specific
arguments from __VA_ARGS__.

Fix athenaHLT running: make initialization happen after fork

See merge request atlas/athena!71218

Stewart Martin-Haugh authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Fix athenaHLT running: make initialization happen after fork