Corrections to L1Calo content in Trigger EDM [ATR-29280]

See merge request !71107

Teng Jian Khoo authored 10 months ago and Tim Martin committed 10 months ago

Corrections to L1Calo content in Trigger EDM [ATR-29280]

TrigTauMonitoring: Fix for coarse pT distributions

See merge request !71291

Jean Yves Beaucamp authored 10 months ago and Tim Martin committed 10 months ago

TrigTauMonitoring: Fix for coarse pT distributions

Removing the overlap b/w EB PhysicsHigh and Medium Seeds

See merge request !71318

Update info message in MuonCalibrationConfig

See merge request atlas/athena!71319

Thomas Strebler authored 10 months ago and Tadej Novak committed 10 months ago

Update info message in MuonCalibrationConfig

ATR-29330: Move L1_4J15 and the HLT chains seeded by it in the MC Menu

See merge request !71313

Marta Lanzac Berrocal authored 10 months ago and Tim Martin committed 10 months ago

ATR-29330: Move L1_4J15 and the HLT chains seeded by it in the MC Menu

TrigP1Test: update BeamSpot.ref

See merge request !71316

Fix allow truncation, postponing the interface serialisation

See merge request !71306

Francesca Pastore authored 10 months ago and Tim Martin committed 10 months ago

Fix allow truncation, postponing the interface serialisation

MuonSelectorTools+ElectronPhotonSelectorTools: Use Accessor, etc instead of auxdata().

See merge request atlas/athena!71308

RootUtils: Delay setting root error handler.

See merge request atlas/athena!71292

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

RootUtils: Delay setting root error handler.

The ROOT error handler used by WithRootErrorHandler was being set when the
RootUtils library was loaded.  However, that may be too early; in particular,
the ATLAS RNTuple code sets a temporary error handler.

Change to setting the handler the first time WithRootErrorHandler gets called.

By the time we're called, there may be multiple threads running,
so it is in principle not safe to call SetErrorHandler.
However, there shouldn't be anything else in Athena calling it,
so in practice it should be ok.  As an extra check, we abort if the
handler we get back isn't what we set, indicating a potential race.

See ATLASRECTS-7967.

FPGATrackSimBankGen: Fix property initialization.

See merge request atlas/athena!71304

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimBankGen: Fix property initialization.

Fix typo in initialization of Gaudi property.

FPGATrackSimHough: Fix signed/unsigned comparison warnings.

See merge request atlas/athena!71302

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimHough: Fix signed/unsigned comparison warnings.

Fix signed/unsigned comparison warnings for Gaudi properties.

PyDumper: Support evgen files.

See merge request atlas/athena!71293

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

PyDumper: Support evgen files.

Support for dumping evgen files: we should't try to set up the geometry
in this case.

JetSubStructureMomentTools+JetCalibTools+JetMomentTools: Use Accessor, etc instead of auxdata().

See merge request atlas/athena!71307

FPGATrackSimSGInput: Fix cppcheck warnings.

See merge request atlas/athena!71305

FPGATrackSimMaps: Fix cppcheck warnings.

See merge request atlas/athena!71311

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimMaps: Fix cppcheck warnings.

Out-of-bounds array accesses.
Redundant map lookup.
Copying values in range-for.

FPGATrackSimAlgorithms: Fix cppcheck 2.14 warnings.

See merge request atlas/athena!71310

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimAlgorithms: Fix cppcheck 2.14 warnings.

Copying values in range-for.
Potential use of invalidated iterators.
Prefer range-for.
sprintf format/argument match.  sprintf buffer size.
Pass objects by const reference, not by value.
Prefer returning const references to members rather than copies.

FPGATrackSimBanks: Fix cppcheck 2.14 warnings.

See merge request atlas/athena!71309

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

FPGATrackSimBanks: Fix cppcheck 2.14 warnings.

Delete copy/assignment from class that manages memory.
Unknown macro.
Prefer returning const references to members rather than copies.
Prefer to pass strings/containers by const reference rather than value.

CPAlgorithms: allow to configure muon minimum pT

See merge request atlas/athena!71294

Baptiste Ravina authored 10 months ago and Tadej Novak committed 10 months ago

CPAlgorithms: allow to configure muon minimum pT

MuonGeoModelTestR4: cmake fix

See merge request atlas/athena!71296

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

MuonGeoModelTestR4: cmake fix

Missing find_package for ROOT.

Hello,

Following the update of trigger ART test inputs (!71286), we need to update the reference file for test_trigP1_BeamSpot_build (ATR-29374).

Cheers,
Bertrand

[TrigEgamma] Fixing IsolationTool configuration

See merge request !71314

TrigValidation and TriggerJobOpts: update ART data inputs, move to CONDBR2-HLTP-2024-01

See merge request !71286

Bertrand Martin Dit Latour authored 10 months ago and Tim Martin committed 10 months ago

TrigValidation and TriggerJobOpts: update ART data inputs, move to CONDBR2-HLTP-2024-01

Hello,

This MR is updating the RAW data files used in trigger ART tests: data22 files from EnhancedBias and Main streams are replaced with the freshly recorded EB run 475321.
For offline reconstruction, the bulk conditions tag and detector geometry were updated to the latest defaults.
We take this opportunity to update the HLT global conditions tag (CONDBR2-HLTP-2024-01), which is already deployed at P1 via a patch.
L1MuonSim RPC readout settings are also adjusted for EB data reprocessing (they are not updated for MC, as discussed in ATR-29238).
The new inputs are already on cvmfs.

Cheers,
Bertrand