Scott Snyder authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

AtlasGeoModel: Support IgnoreTagDifference for CA configuration.

To allow processing samples that were generated	with geometries	which were
later made non-supported.

Pass string by const reference, not by value.

Christos Anastopoulos authored 1 year ago and Frank Winklmeier committed 1 year ago

TRT_BaseElement, SolidStateDetectorElementBase : Inline some simple 'final' methods that are called quite a bit

Christos Anastopoulos authored 1 year ago and Frank Winklmeier committed 1 year ago

ATH_FLATTEN related fixes

In 4.6.0 GeoModelIO::ReadGeoModel::buildGeoModel() returns a pointer to GeoVPhysVol
instead of GeoPhysVol as in earlier versions

Christos Anastopoulos authored 1 year ago and Tadej Novak committed 1 year ago

vec_parametrized_sincos: actually enable avx2+fma (x86-64-v3) . Use newer syntax for the attribute

Johannes Junggeburth authored 1 year ago and Tadej Novak committed 1 year ago

GeoModel - Remove PVConstLink includes and predefinitions

Chad Stephen Lantz authored 1 year ago and Julien Maurer committed 1 year ago

Update of ZDC geometry using ZdcIdentifier ATLASSIM-6751

If GeoModel is initialized from SQLite, then IdDictDetDescrCnv first attempts to read
ID dictionaries from SQLite tables in BLOB format. In case of success, the dictionaries
will be written out as XML files into the run directory and passed to the dictionary
parser for further processing.

This can be considered an interim solution aimed to avoid making any changes in the
ID dictionary parser, and in this way to support several options for ID dictionary
initialization:
1. Retrieve ID dictionary file names from Geometry DB tables
2. Retrieve ID dictionary file names from SQLite database tables
3. Retrieve ID dictionaries as BLOBs from SQLite database tables

Later we can consider dropping the step of writing BLOBs on disk as XML files, and
instead passing them as strings to the dictionary parser.

Johannes Junggeburth authored 1 year ago and Walter Lampl committed 1 year ago

GeoModelTransientPtr - Modify constructor to accept child class pointers

Johannes Junggeburth authored 1 year ago and Walter Lampl committed 1 year ago

GeoPrimitives - Fix small printout typo

Johannes Junggeburth authored 1 year ago and Edward Moyse committed 1 year ago

MuonGeoModelR4 - Continue development of the Tgc Readoutelements & misc clean-up

Johannes Junggeburth authored 1 year ago and Johannes Elmsheuser committed 1 year ago

Use Algebra & StringHelpers from ActsGeoUtils package

Johannes Junggeburth authored 1 year ago and Johannes Elmsheuser committed 1 year ago

AGDD - Ensure that GeoPrimitives are included before GeoModel

Add the `AccumulatorCache` to all regSel Cfg function. Saves about one
minute in trigger configuration time.

Relates to ATR-26996.

Scott Snyder authored 1 year ago and Johannes Elmsheuser committed 1 year ago

RegionSelector: Fix cppcheck warning.

Pass strings by const reference, not by value.
Remove method declaration with no corresponding definition.

Scott Snyder authored 1 year ago and Johannes Elmsheuser committed 1 year ago

AGDDModel: Fix cppcheck warnings.

Pass strings by const reference, not by value.

In general, we do not support all possible geometry configurations in
reco (e.g. not all Muon detectors can be configured individually). Hence
only toggle the detector flags but not the geometry flags. Also set a
proper conditions and geometry tag.

Fix the failing Muon and LAr unit test by configuring the detector
geometry.

Fixes ATLASRECTS-7290 and ATLASRECTS-7292.

Johannes Junggeburth authored 1 year ago and Adam Edward Barton committed 1 year ago

MuonReadoutGeometryR4 - Add alignable nodes

Scott Snyder authored 1 year ago and Adam Edward Barton committed 1 year ago

Identifier: Force Range to compile with optimization.

Force Range to compile with opimization, even in debug builds.
This significantly speeds up some tests, for example
MuonCondDump_TestMdtCablingDump.

Suppress a cppcheck false positive.

Scott Snyder authored 1 year ago and Tadej Novak committed 1 year ago

Identifier: Add begin() and end() to MultiRange.

Allow using a MultiRange object in a range-for.

Johannes Junggeburth authored 1 year ago and Tadej Novak committed 1 year ago

TransientConstSharedPtr - Add dereference operator

Mark Sutton authored 1 year ago and Tomasz Bold committed 1 year ago

Fix JetSuper Roi constituent management

The JetSuper Roi was being told to *not* manage it's constituents, but then
mistakenly, unique_ptr was being used to created those constituents, but of course,
as they were being stored as standard pointers, they were being released first,
so the unique pointer was no longer managine them, and they were no longer being
managed by unique_ptr and were subsequently leaking when the superRoi was being
destroyed.

In principle the unique_ptr could have then been reset() with the now, standard
ptr, but then the now standard constitent pointer i the Roi would not have been
safe to use once the unique_ptr had gone out of scope  - it would have still be
there, but could the memory be treclaimed at some later stage ? So would it be safe
to use ? I suspect not, and almost certainly calling delete on it would cause a
malloc error as the address would have already been deleted when the unique_ptr
went out of scope.

As such unique_ptr are in appropriate here, and so we resort back to good old "new"
and let the Roi manage it's consituents itself.

All Roi copies are deep copies of the constituents now, so this is guaranteed safe.

Apart from the L1-related functions, none of the methods in the `RoiDescriptor` class
are ever overridden. Marking them as `final` may allow the compiler to
perform inlining in specific scenarios.

Relates to ATR-27858.

Instead of the complicated function pointer logic, simply set a flag when the first
`RoiDescriptor` has been created and throw an exception in case the z-width
is being changed afterwards.

- remove `_internal` methods from public interface and replace by lambda
- delete legacy `roiContains` methods
- remove `ifdefs` for PI constants
- use range-based loops

Andrii Verbytskyi authored 1 year ago and Walter Lampl committed 1 year ago

Use CxxUtils:: instead of boost:: for stats_with in GeoModel

Fix warning about potential use of unitialized data, seen in the lto build.

Fixed IdDictDetDescrCnv to allow GeoModel initialization from SQLite

Selaiman Ridouani authored 1 year ago and Walter Lampl committed 1 year ago

Flip local coordinate of HGTD SiHit at GeoSiHit

Scott Snyder authored 1 year ago and Julien Maurer committed 1 year ago

IdDictDetDescrCnv: Fix clang warnings.

Missing override keyword.
Self-reference during initialization.