Frank Winklmeier authored 1 year ago and Melissa Yexley committed 1 year ago

Delete the legacy runHLT_standalone job options and related utilities.

Jennifer Rachel Curran authored 1 year ago and Melissa Yexley committed 1 year ago

Removal of functions to add differences in pre/pos trees as added to a later step and check on if an event status name is present for events that do not have an explicit 0 set

Jennifer Rachel Curran authored 1 year ago and Melissa Yexley committed 1 year ago

Fix to read to end of string in line for accepted/rejected events so that for runs where accepted/rejected > 9, the events won't be cut off

Scott Snyder authored 1 year ago and Melissa Yexley committed 1 year ago

TrigPSC: Update for python 3.11.

Update the passing of command-line arguements to python;
PySys_SetArgv is deprecated as of 3.11.

Jennifer Rachel Curran authored 1 year ago and Melissa Yexley committed 1 year ago

Debug stream recovery, Fix to trig reco

Jennifer Rachel Curran authored 1 year ago and Adam Edward Barton committed 1 year ago

Addition of new function to add a Tree and histograms that show the difference in the Pre/Pos histograms in dbgAnalysis, modification of a function to add in the HLT_accepted_events histogram along with HLT_rejected_events as well as an additional python file that creates an empty file with the BSFile structure and changes to trigRecoExe to accomodate these additional functions and to rename the empty BSFile to RAW.pool.root if no events are selected for the chosen streams to prevent failures at T0 when events are actually just rejected by the HLT and/or stream selection when running the TriggerTransform for debug recovery.

Mark Stockton authored 1 year ago and Johannes Elmsheuser committed 1 year ago

CA updates for TriggerTransform

Scott Snyder authored 1 year ago and Johannes Elmsheuser committed 1 year ago

TrigPSC: Fix cppcheck warnings.

Pass objects by const reference, not by value.
Prefer to initialize class members in an initialization list.
Blank macro arguments can confuse cppcheck.

Stewart Martin-Haugh authored 1 year ago and Frank Winklmeier committed 1 year ago

Set scheduler defaults to match runHLT in PSC

ALFA does not need to be supported anymore (ATR-28444).

Clean up memory management.

Stewart Martin-Haugh authored 1 year ago and Frank Winklmeier committed 1 year ago

Migrate TimeBurner, MistimeMon to CA (ATR-28359)

Andrii Verbytskyi authored 1 year ago and Johannes Elmsheuser committed 1 year ago

Remove the linkage to boost libraries in case only header-only components are used

The HLTMPPU implementation of MonSvc is not thread-safe. To prevent any
possible issues, add an extra lock also to the `deReg(const std::string&)`
method following what is being done for all other methods.

Maybe related to ATR-28222.

Fix ALFA LB histogram (ATR-27909).

Fix two issues that prevented the LB histograms to be filled correctly:
- Two `Monitored::Scalar` with the name "y" were used. Rename one of
  them to "ay" and adjust `defineHistogram` calls.
- Remove the `_LB` suffixes from the axis variables to match the C++
  code.

Closes ATR-27909.

Andrii Verbytskyi authored 1 year ago and Adam Edward Barton committed 1 year ago

Drop boost::lexical_cast in the places wher std::to_string will work

- `Trigger.DecodeHLT` -> `Trigger.decodeHLT`
- `Trigger.endOfEventProcessing.Enabled` -> `Trigger.enableEndOfEventProcessing`
- `Trigger.HLTSeeding.forceEnableAllChains` -> `Trigger.forceEnableAllChains`

Tadej Novak authored 1 year ago and Frank Winklmeier committed 1 year ago

Trigger: implement rewriteLVL1 feature in CA

See merge request atlas/athena!65052

(cherry picked from commit 018455eb)

e45a3c4f TrigPSC: set writeBS=True by default and support doL1Sim
e008ed83 TrigServices+TriggerJobOpts: implement rewriteLVL1 feature in CA
58d37c70 TriggerJobOpts: deprecate rewriteLVL1 modifier

This reverts merge request !64860

Implement the equivalent of the `rewriteLVL1` Modifier for CA. Instead
of introducing yet another flag, we assume that when the LVL1 simulation
and BS-writing is enabled, we always want to write out the updated
LVL1 result.

Relates to ATR-26582.

Enable BS-writing by default and fully support the `doL1Sim` Modifier of
runHLT_standalone. The corresponding flag needs to be set early on to
avoid merge conflicts in TrigServicesCfg.

Also need to set default `EDMVersion` in order for the
auto-configuration to work correctly.

Joerg Stelzer authored 1 year ago and Michele Faucci Giannelli committed 1 year ago

ALFARobMonitor multi-LB hist publish by default

Rewrite the unit test to use the regular state machine to avoid issues
with finalization order. Also remove the rather useless check on the
execution time which is way too generous to be useful.

Closes ATR-27962.

We are using 32 MB as the default event/result size limit online (set
via `DcmApplication.sbaBlockSize_MiB`). Use the same value for
`athenaHLT` to make it easier to reproduce the same behavior.

TrigJetHypo ATR-27619 - reduce the number of AlgTools.

TrigJetHypo ATR-27619 - reduce the number of AlgTools.

Replace the on to one matching of Condition filters - Conditions with an
index array, and a Filter array. The index array is one-to-one with the Conditions,
while the size of the filter array is at most the length of the filter index array.

In the majority of cases, the condition filters were pass-through filters, so this
approch reduces the need to configure the such filters, at the proce of more complex code.

Further, the filter used before the processing the jet hypo, has been replaced by a simple copy
when a PassThrough filter was requested.

Jennifer Rachel Curran authored 1 year ago and Stewart Martin-Haugh committed 1 year ago

Debug stream recovery, Fix for addition of HLT_rejected_events histogram

Andrii Verbytskyi authored 1 year ago and Walter Lampl committed 1 year ago

Use C++17 std::filesystem instead of boost::filesystem where possible

Jennifer Rachel Curran authored 1 year ago and Chandler Robert Baker committed 1 year ago

Debug Stream recovery, addition of HLT_rejected_events histogram

Mark Stockton authored 1 year ago and Lydia Brenner committed 1 year ago

Trig_reco_tf updates - list of streams, working directory check

Andrii Verbytskyi authored 1 year ago and Walter Lampl committed 1 year ago

Remove unused boost in LArMonitoring

Andrii Verbytskyi authored 1 year ago and Walter Lampl committed 1 year ago

Remove unused boost subpackages from CMakeLists.txt

- increase event ID field width from 4 to 6 digits
- do not overwrite MessageSvc format in runHLT for online (fixes the
  missing timestamps)

Run with strict dependency checking by default in athenaHLT. This was
already done in runHLT, so only impacts other testing job options.

Avoid running with auto-loading of missing dependencies.