Baptiste Ravina authored 11 months ago and Edward Moyse committed 11 months ago

new overlap removal scheme based on the nominal-OR decision, but run also for systematically-varied kinematic selections

Joseph Earl Lambert authored 1 year ago and Frank Winklmeier committed 1 year ago

move order of thinning block right before output

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: run FTag after JVT and OverlapRemoval are applied

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: use Gaudi::Property and ToolHandles everywhere

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: an easier way to disable global trigger matching and efficiency

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: add ability to select events based on global trigger matching in the EventSelection block

CPAlgorithms: add ability to select events based on global trigger matching in the EventSelection block

Thomas Strebler authored 1 year ago and Frank Winklmeier committed 1 year ago

Use JVT selection in Jets.FlavourTaggingEventSF block

Thomas Strebler authored 1 year ago and Frank Winklmeier committed 1 year ago

Fix ElectronAnalysisConfig BLayer working points

Nils Erik Krumnack authored 1 year ago and Frank Winklmeier committed 1 year ago

sort PHYSLITE output objects by PT (ATLASG-2685)

For simple analysis it is nicer if the objects are just sorted
by pt.  This doesn't work with systematics at all, but without
systematics this should (hopefully) work.

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: add truth-b-label to jets for JES uncertainties

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: provide default GRLs

Thomas Strebler authored 1 year ago and Frank Winklmeier committed 1 year ago

Move FTagEventSF to standalone analysis config

Will Buttinger authored 1 year ago and Walter Lampl committed 1 year ago

Update AsgClassificationDecorationAlg.cxx - tool must be private for consistency with https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms/python/AsgAnalysisConfig.py#L380

Baptiste Ravina authored 1 year ago and Walter Lampl committed 1 year ago

CPAlgorithms: distinguish between MC and data when writing output branches

Joseph Earl Lambert authored 1 year ago and Walter Lampl committed 1 year ago

CPAlgs block dependencies: reorder blocks based on dependencies

The different blocks used for the CP algorithms are given a name.
The name usually correspond to the class name.

Dependencies can be added to a block based off of the given name.

Joseph Earl Lambert authored 1 year ago and Walter Lampl committed 1 year ago

ConfigBlock: remove groupName, change noneAction, and duplicateAction

The groupName variable was changed to blockName and set from a
set/get function.

Add instanceName to identify specific instances when there is a
desire to set the value of an option in an arbitrary location and
there is more than one instance of a block.

Removed code to potentially throw an error if an option was
set more than once.

Instead of haing the user say "I am setting this option to None
and it is okay," the noneAction variable can be set when adding
an option. If the author of a class determines that an option
can be set to None, then they can set this for that option.

Bertrand Martin Dit Latour authored 1 year ago and Walter Lampl committed 1 year ago

TauAnalysisTools: Use data handles in BuildTruthTaus

Still WIP

Oliver Majersky authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

CP algorithms: rename the jvt selection name to something more explanatory

Essentially this ensures that users don't misspell their selection
names, or use a selection name they forgot to define.

This is only for full selections, for preselections I don't do
it, as I usually ask for them before they are defined.  I also
don't do it for the baseline selection.  If that is not present
that just happens.

Oliver Majersky authored 1 year ago and Tadej Novak committed 1 year ago

Revert "Remove FTAG selectionNmaes that are actually never used."

This reverts commit 436ed695.

This is a followup to !68703 that uses that mechanism to add factories for
all components used by the common CP algorithms.  This is not necessarily
the prettiest way of doing things, but it is what can be practically done
right now with little effort.  It should probably be replaced by a better
mechanism at some point.

Command to test/run this:
```
FullCPAlgorithmsTest_eljob.py --data-type data --algorithm-memory --factory-preload 'libComponentFactoryPreloaderDict.so,CP::preloadComponentFactories' --block-config --use-flags
```

The basic idea here is that dictionaries are fairly heavy when used as a factory.  Registering factory functions instead makes the jobs a lot lighter.
For the CP algorithm test job (on data) the savings are:

~600 MB in memory
~22s in startup time
one major root dependency eliminated

The first draft also included a function for preloading all the dictionaries.  I removed
it to allow the user to define their own.

Baptiste Ravina authored 1 year ago and Frank Winklmeier committed 1 year ago

CPAlgorithms: bugfix for PerEventSFBlock

James Catmore authored 1 year ago and Vakhtang Tsulaia committed 1 year ago

Removal of legacy config for DAOD production - part 4

This MR removes much of the legacy DAOD-making configuration code, such that the old-style reductionConf argument to Reco_tf will no longer work.

Some of the packages touched here may be completely obsolete and so more deletion may be possible, but for this MR the changes are restricted to DAOD building.

Thomas Strebler authored 1 year ago and Tadej Novak committed 1 year ago

Add FTag event scale factor CP algorithm config

Thomas Strebler authored 1 year ago and Tadej Novak committed 1 year ago

Remove deprecated runSelection and globalSF from JetJvtAnalysisConfig

Baptiste Ravina authored 1 year ago and Tadej Novak committed 1 year ago

CPAlgorithms: refactor the object cutflow

Scott Snyder authored 1 year ago and Tadej Novak committed 1 year ago

AthContainers: Update copy/copyForOutput to work on AuxVectorData.
    
Update the copy/copyForOutput methods of IAuxTypeVectorFactory / AuxTypeRegistry
to take AuxVectorData instances rather than bare pointers.
Remove the corresponding static methods from AuxTypeVector.

Refactoring to make possible dependencies between auxiliary variables,
as would be used to support packed links / jagged vectors.
Also alter them to operate on ranges, rather than a single element.

Revert "Merge branch 'bugfix_objectcutflow' into 'main'"

This reverts merge request !68554