- Feb 20, 2024
-
-
Use `[]` to access flags by name.
-
AthContainers: Move variable flags to AthContainersInterfaces. Move variable flag definitions out of AthContainersInterfaces and define them instead in AthContainersInterfaces/AuxTypes.h. Needed to avoid a cyclic header dependency.
-
Revert "LArConditionsTest: remove log-diff'ing in favor of noerrror.sh" This reverts commit 103090ce.
-
Moving constants and simple methods related to naming of storage containers - that are used in other packages - into separate a independent header
-
-
Fix an object deletion order issue in the unit test which was causing a test failure in the dbg build.
-
[ATR-28716] Refactor Calo GPU flags
-
-
Remove the legacy version of the `GenericMonitoringTool` as all workflows should have been migrated to CA. This also removes the need for the `def GenericMonitoringTool` function as we can now directly use class instantiation.
-
-
-
AthContainers: Update return type of auxdata methods of AuxElement. For the auxdata methods of AuxElement, take the return type from the Accessor class that's used, rather from the AuxDataTraits class. This lets us handle the case where Accessor<T> returns something other than T (such as for packed links / jagged vectors).
-
Comparison of integer expressions of different signedness
-
-
Suppress a cppcheck false positive.
-
Otherwise, default conversions will allow initializing a DecorHandle with a DecorHandleKey of the wrong type, producing confusing errors at runtime.
-
Implement proper support for GaudiConfig2 for the python components. The basic idea is to dynamically (on `import`) change the base class of of `CfgPyAlgorithm`, etc. Implement a trivial `merge` method that checks if two instances are identical. More complicated merge logics would have to be implemented in derived classes. This also removes the need for special handling in the `ComponentAccumulator`.
-
MuonConfiguration - Auto detect whether the R4 style or legacy geometry are loaded
-
-
The `getFullName` workaround is not needed anymore as the base class now provides `getFullJobOptName`.
-
Fix the following warning that shows up in developer mode (e.g. unittest): ``` AthenaCommon/Debugging.py:81: ResourceWarning: unclosed file ```
-
-
In order to remove hard dependencies on the legacy configurables in CA jobs, only import them when needed.
-
-
Cleanup the code of the python components, reduce copy&paste and introduce common base class. No functional changes.
-
Revert "remove deprecation on __call__, again" This reverts commit 1b3d761e.
-
Revert "remove redundant packages" This reverts commit 0ac0c9a2.
-
AthContainers: Update copy/copyForOutput to work on AuxVectorData. Update the copy/copyForOutput methods of IAuxTypeVectorFactory / AuxTypeRegistry to take AuxVectorData instances rather than bare pointers. Remove the corresponding static methods from AuxTypeVector. Refactoring to make possible dependencies between auxiliary variables, as would be used to support packed links / jagged vectors. Also alter them to operate on ranges, rather than a single element. -
Introduced new command-line argument for job transforms --geometrySQLiteFullPath to ovveride standard path to the SQLite Geometry Database. If this argument is used then GeoModelSvc switches to the initialization of geometry from SQLite and takes the SQLite database path from the overrider instead of trying to find the file in the standard location
-
AthAllocators: Fix potential deadlock. In ArenaHeader::allocator(), we need to release the header lock before creating the LockedAllocator instance. Otherwise we can deadlock if an algorithm creates multiple allocators. See ATR-28749.
-
AthContainers: Avoid cppcheck false positive. Reorder declarations to avoid cppcheck false positive.
-
Fix the gatherProps unit test (was not running at all) and extend it to check ordering of the new `set` properties in Gaudi v38.
-
CxxUtils: Mark that CxxUtils::span is a view. Add at(). For C++20, CxxUtils::span should derive from view_base in order for it to be usable as a view with the ranges library. Also, add at() methods. (These are C++26.)
-
-
Fix default behaviour of the comps filtering in confTool
-
When comparing property values, compare the actual values rather than their string representation. This ensures that two `set` properties are considered equal even if their order is different. Also ignore `ConditionStore+` prefix when comparing handle defaults.
-
-
Introduce "compatible types" that can be implicitly converted to each other (e.g. assigning an `int` to a `float` flag). Also ensure that the type checking is done when assigning flags from the command line. Previously, assigning a `float` value to an `int` flag would explicitly convert the value to an integer (and cut off the decimals) without error message.
-
Ignore numeric differences in nested lists, e.g. the following diff ``` PtBins = [[0, 1.05, 1.5, 2.0, 9.9]] vs [[0.0, 1.05, 1.5, 2.0, 9.9]] << ``` is now marked correctly as "known difference".
-
Update the clear method of IAuxTypeVectorFactory / AuxTypeRegistry to take AuxVectorData instances rather than bare pointers. Remove the clear static method from AuxTypeVector. Also alter clear to operate on a range, rather than a single element. Refactoring to make possible dependencies between auxiliary variables, as would be used to support packed links / jagged vectors.
-
