tauRecTools: add TauGNNEvaluator to dictionary

See merge request atlas/athena!77472

Bertrand Martin Dit Latour authored 2 months ago and Jean-Baptiste De Vivie De Regie committed 2 months ago

tauRecTools: add TauGNNEvaluator to dictionary

Hello, we were missing a tool in the tauRecTools dictionary. This was noticed when trying to schedule TauGNNEvaluator in our THOR tuning framework.

Cheers,
Bertrand

AthenaConfiguration: minor code cleanup for setting properties

See merge request atlas/athena!77442

AthOptionsParser: fix athena --help

See merge request atlas/athena!77450

Update to CMake installation of TriggerMenuRulebook

See merge request atlas/athena!77446

Teng Jian Khoo authored 3 months ago and Petar Bokan committed 3 months ago

Update to CMake installation of TriggerMenuRulebook

Fix ID Trigger monitoring

See merge request atlas/athena!77438

Mark Sutton authored 3 months ago and Petar Bokan committed 3 months ago

Fix ID TRigger monitoring

After the changesntop the data file and menu many of the trigger chains had changed,
and much of the monitoring was not working. After extensive changes, it still was not
working since getting the changes to the chains and the analyses was difficult to synchronise.

Therefore some additional scripts to autogenerate the chains dependent config files and so on
from a single central config file have been added. These scripts are not ideal - it would be
better to use a central config file directly in the jobs, but we have files in python, json files,
and files in a custom format, so getting them all to use some central config file would be none
trivial.

As many of the jobs and chains are now different, then most of the references will have to be
updated so the oportunity was also taken, to fix the default PT cut back to 1 GeV for the
moniotring rather than 2 GeV threshold that was being used by default for some reason.

Egamma Trigger Monitoring Flag

See merge request atlas/athena!77422

Juan Lieber Marin authored 3 months ago and Petar Bokan committed 3 months ago

Egamma Trigger Monitoring Flag

The `athena --help flags` was not working under all circumstances, i.e.
when used with `--help=flags`. Instead of modifying the command line
arguments in `sys.argv`, temporarily disable the help actions in the
argument parser itself.

AthenaConfiguration+AthenaPoolCnvSvc: Allow marking streams as temporary and use ZSTD to compress temporary files instead of ZLIB when possible

See merge request atlas/athena!77412

Alaettin Serhan Mete authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

AthenaConfiguration+AthenaPoolCnvSvc: Allow marking streams as temporary and use ZSTD to compress temporary files instead of ZLIB when possible

Merge branch 'main-introduce-temp-streams' into 'main'

AthenaConfiguration+AthenaPoolCnvSvc+OutputStreamAthenaPool: Add a new flag to mark streams temporary when applicable

See merge request atlas/athena!73463

MCRecoTruth: quasi-stable particles may be matched to reconstructed tracks

See merge request atlas/athena!77411

John Derek Chapman authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

MCRecoTruth: quasi-stable particles may be matched to reconstructed tracks

Minor code cleanup in the `setupLoggingLevels` and `PropSetterProxy`
code, i.e.:
  - print warning in case no property matches
  - improve documentation
  - retrieve `MessageSvc` only when needed

TrigEgamma online monitoring updates and new flag for iso validation

See merge request atlas/athena!77399

Edmar Egidio Purcino De Souza authored 3 months ago and Tim Martin committed 3 months ago

TrigEgamma online monitoring updates and new flag for iso validation

TrigHLTJetHypoUnitTests: remove thread-checker suppressions

See merge request atlas/athena!77405

ThinGeantTruthAlg: ensure that the products quasi-stable particle interactions are kept

See merge request atlas/athena!77376

John Derek Chapman authored 3 months ago and Duc Ta committed 3 months ago

ThinGeantTruthAlg: ensure that the products quasi-stable particle interactions are kept

Any "simulation particles" with a parent with status==2 were produced via the
interaction of a quasi-stable particle with the detector material. Such particles
should be kept.

Should fix issues observed in ATLPHYSVAL-1154.

ZdcAnalysis: thread-checker cleanup

See merge request atlas/athena!77402

Suppressions are no longer needed.

Move thread-safety declaration to class level and fix mutable/const
violations.

HLTCalo: Cherry picking relevant changes from main to 24.0

See merge request atlas/athena!77389

Walter Lampl authored 1 year ago and Nuno Dos Santos Fernandes committed 3 months ago

CaloNoise: Add  method to get getEffectiveSigma by IdentiiferHash
(cherry picked from commit c6670c14)

Scott Snyder authored 3 months ago and Nuno Dos Santos Fernandes committed 3 months ago

TrigCaloRec: Fix clang warning.

Binding reference to temporary in range-for.

(cherry picked from commit cbdc8d08)

Vakhtang Tsulaia authored 6 months ago and Nuno Dos Santos Fernandes committed 3 months ago

TrigCaloRec: Separate monitoring algorithm

See merge request atlas/athena!74220

(cherry picked from commit 2ae966ac)

Walter Lampl authored 8 months ago and Nuno Dos Santos Fernandes committed 3 months ago

CaloRec: Add option to create trigger decorations to Cluster Maker

See merge request atlas/athena!73946

(cherry picked from commit 83d116df)

Store PixelCluster variables in DAOD_PIXELVALID

See merge request atlas/athena!77357

Filippo Dattola authored 3 months ago and Duc Ta committed 3 months ago

This merge request introduces the code needed to store PixelCluster variables in DAOD_PIXELVALID for luminosity studies with Pixel Cluster Counting.

Detailed description is provided in this presentation

https://indico.cern.ch/event/1501124/contributions/6319616/attachments/2996403/5279088/cluster_selection_18_12_2024.pdf

but the key features are:

1) introduction of a tool for the thinning of PixelClusters in Athena’s InDetToolsConfig (specific selection for lumi studies);

2) introduction of a PixelDumpMode 5 in the PixelVALIDCfg of Athena’s PIXELVALID -- in case of dump mode 5 import and execute the thinning tool within the PIXELVALIDThinningKernelCfg of PIXELVALID;

3) allows to store PixelCluster variables in DAOD_PIXELVALID in case of case of dump mode 5.

AthContainers+AthViews: Don't copy decorations with an AuxElement.

See merge request atlas/athena!77365

Scott Snyder authored 3 months ago and Duc Ta committed 3 months ago

AthContainers: Don't copy decorations with an AuxElement.

When we copy an AuxElement, don't copy decorations.  Another thread
may be modifying them, which can lead to corruption/crashes.
See ATLASRECTS-8008.

L1CaloFEXSim: fix cppcheck false positive

See merge request atlas/athena!77370

JfexMonitorAlgorithm: thread-safety fixes

See merge request atlas/athena!77372

Enable thread-checker and use `std::call_once`.

Replace C-style cast with `static_cast` to avoid cppcheck false positive
in ARM build.