Skip to content
Snippets Groups Projects

always check valid debug level is specified

Closed Crystal Michelle Chua requested to merge (removed):add-debuglevel-check into dev

debug level value is only checked when applied locally additionally, an invalid debug level still incorrectly displays a success message in the console (but will display the error in the log file)

EOS Console [root://localhost] |/> debug warn /eos/*/fst
success: switched to mgm.debuglevel=warn on nodes mgm.nodename=/eos/*/fst

EOS Console [root://localhost] |/> debug warn /eos/*/fst
success: switched to mgm.debuglevel=warn on nodes mgm.nodename=/eos/*/fst
success: switched to mgm.debuglevel=warn on nodes mgm.nodename=/eos/*/mgm
error: debug level warn is not known! (errc=22) (Invalid argument)

EOS Console [root://localhost] |/> debug warn
error: debug level warn is not known! (errc=22) (Invalid argument)

modified to always check before sending:

EOS Console [root://localhost] |/> debug cats
error: debug level cats is not known! (errc=22) (Invalid argument)
EOS Console [root://localhost] |/> debug cats *
error: debug level cats is not known! (errc=22) (Invalid argument)
EOS Console [root://localhost] |/> debug cats /eos/*/fst
error: debug level cats is not known! (errc=22) (Invalid argument)
Edited by Crystal Michelle Chua

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 516 commits

    • ce130a11...b3f021ec - 488 commits from branch dss:master
    • 6a51f5c6 - MGM: Add routing endpoint status update mechanism to detect if the corresponding
    • 2b004a33 - MGM: Implement stalling for routes where none of the endpoints is online
    • fd19dc48 - COMMON: Make the std::shared_timed_mutex the default implementation for RWMutex
    • 517d30d0 - MGM: Fix typo
    • a0678ab9 - MGM: don't let a secondary replica wipe preset etags in atomic uploads
    • 87ba96bf - MGM: Fix collection of unlinked locations for a file which is crashing the MGM
    • 60729ee5 - FUSEX: clean-up buffers from failed async read requests and avoid to do…
    • b94f78ad - CI: Allow system tests to fail for now
    • 3e674e46 - CI: Fix previous commit
    • 5ab86129 - MGM: Fix unprotected access to the configuration hash leading to a crash
    • 53f4cbe0 - MGM: Remove extra mutex lock
    • 946a3e00 - MGM: treat (inode-quota=0) in project quota as infinite quota
    • 7dc728ad - FUSEX: use the lazy unmount option in the umounthandler and return flush error…
    • 3d97e29d - FUSEX: fix factor 1024 off default value for the nominal read-ahead
    • 0e72d9f2 - FUSEX: fix overshooting the read-ahead value over the maximum possible one
    • 4b076786 - MGM: let oc-uploads set the mtime in commits and remove a previous temporary ETAG
    • 0856e3a9 - MGM: Adjust indentation in fsctl/Commit
    • db2fd079 - ALL: Minor comment adjustments
    • 9eb62646 - FST: Fix linkage of both eosCommon & eosCommonStatic in eos-scan-fs tool
    • f97d7826 - MGM: Add switch to the SetConfigValue method to decide when to take the lock
    • 9b4f8616 - MGM: Fix access command to first store modifications and then broascast them
    • be5e310c - MGM: Fix race condition when updating the global config map
    • 631de01d - SPEC: Add libEosFstIo to the spec file
    • d1da49bd - NS: Fix buggy mtime handling
    • 52ee0349 - SPEC: Put back library removed by mistake
    • 0b52180e - MGM: bridge 'xc-oc-mtime' header of a PUT request on the MGM
    • 14ba8a0c - FUSEX: disable 'rm -rf' bulk deletion for the time being
    • 04087a2b - Merge branch 'dev' of https://gitlab.cern.ch/dss/eos into add-debuglevel-check

    Compare with previous version

  • Crystal Michelle Chua changed target branch from master to dev

    changed target branch from master to dev

  • Crystal Michelle Chua changed the description

    changed the description

  • Merged into dev branch manually.

Please register or sign in to reply
Loading