Photon ID and Iso configuration in CP algs
Following up on #115 (comment 7203489) with @khoo, allowing for user configuration of photon ID and Iso working points through yaml
config file.
Files edited:
-
EasyjetHub/python/algs/calibration/photons.py
:- Defined
PhotonWPLabel
based on photon ID and Iso WPs chosen, for naming configuration - Configure
qualityWP
andisolationWP
based on input flags
- Defined
-
bbyyAnalysis/share/yybb-base-config.yaml
:- Set default Photon ID and Iso WPs to ones used in legacy analysis (Tight, FixedCutLoose). Can always be edited by users for studies, but propose leaving defaults to last/latest points used in analysis.
An issue I ran into that I don't understand: When running with the NonIso
Iso working point, the CP algs were not able to properly initialize:
It appeared this was due to the isolation efficiency SF computation done here in the CP algs, so I turned off SF computation if the ISO WP is NonIso
. However, I think this would lead to not computing ID/Reco efficiency SFs...is this something that should be updated in athena/PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms/python/PhotonAnalysisConfig.py
? Or perhaps I'm missing something for computing SFs when not running an isolation?
HHFramework contacts: @tstreble @lderamo
yybb
analyzers for feedback from yybb
point of view: @smeriano @losanti @gdigrego