RpcDigitizationTool -- Introduce checks on identifier validity

Closes ATLASSIM-5320

See merge request atlas/athena!47382

tauRec: implement timing cut on cells that seed pi0 topoclustering

See merge request atlas/athena!47404

PowhegControl: cherry-pick of "Merge branch '21.6-Powheg_ttMiNNLO_Fixes' into '21.6'" - AGENE-2055

See merge request atlas/athena!47411

NSW Trigger RDO merging tool

See merge request atlas/athena!47122

TrigT1Monitoring: do not setup LVL1ConfigSvc in new DQ

Closes ATR-24359

See merge request atlas/athena!47374

TrigT1CaloCalibTools+TrigT1CaloCalibToolInterfaces: Remove some unused code.

See merge request atlas/athena!47389

Separating the electron tag and probe slice from the electron slice in the Art Steps

See merge request atlas/athena!47384

LArMonitoring: delete obsolete LArReco_fromraw.py

See merge request atlas/athena!47407

fix a bug reported in ATR-23809

See merge request atlas/athena!47408

Activate SV1 and JF LH in DAOD_PHYSVAL for FTAG Physics Validation (AFT-574)

See merge request atlas/athena!47409

TriggerJobOpts+RecExCommon: cleanup trigger BS reco

See merge request atlas/athena!47410

AthenaConfiguration: fix python deprecation warning

See merge request atlas/athena!47378

[ATLASRECTS-6630] Update TriggerConfigFlags.py to change Trigger.doNavigationSlimming default to True

See merge request atlas/athena!47386

Resolve ATEAM-777

Closes ATEAM-777

See merge request atlas/athena!47394

update Gaudi Version to v36r2.000

See merge request atlas/athena!47396

Digitization+TBCnv: Remove references to LArRoI_Map.

See merge request atlas/athena!47390

Remove thread unsafe registerColorCode

See merge request atlas/athena!47349

LArConditionsTest+LArEventTest+LArTBRec: Remove references to LArRoI_Map.

See merge request !47300

TrigEgammaHypo: Fix gcc11 warning.

See merge request atlas/athena!47387

VP1CaloSystems+VP1Algs: Remove use of LArLegacyCablingService.

See merge request atlas/athena!47395

MuonDetDescrUtils - Activate thread safety & clang-format

See merge request atlas/athena!47385

Should fix Rivet crashes

See merge request atlas/athena!47316

Fix for the failed ctest: SCT_Monitoring_SCTLorentzMonAlg_test

See merge request atlas/athena!47398

Ewelina Maria Lobodzinska authored 3 years ago and Timothee Theveneaux-Pelzer committed 3 years ago

PowhegControl (21.6): further fixes for ttj MiNNLO - AGENE-2055

See merge request atlas/athena!47381

(cherry picked from commit eea29a5d456ef03a1ff2b53940457b5424a8641a)

adc71d5c Enabling further parameters for ttj_MiNNLO
03276ba2 Adding MadSpin decays for ttj MiNNLO
7af3f601 Fix warning due to integration files which are not produced by ttj MiNNLO
d4f53491 PowhegControl: hack for ttjMiNNLO, bypassing problem of hardcoded path in the fortran code

Delete the obsolete `BStoESD_Tier0_HLTConfig_jobOptions.py`. There was
essentially no difference anymore to the `T0TriggerGetter`, which it
also called, apart from setting the `Trigger.readBS` flag.

Use the `T0TriggerGetter` instead of
`BStoESD_Tier0_HLTConfig_jobOptions.py` to setup the trigger bytestream
reading.

The trigger setup in `LArNoise_fromraw` is not functional. Remove also
the obsolete include of `BStoESD_Tier0_HLTConfig_jobOptions.py`.

These job options have only seen commits from people migrating other
code and trying to keep them up-to-date. However, they have not even
been migrated to Python3, so they are clearly not used.

Hello,

This MR is implementing a timing cut on the cells that seed the pi0 topoclustering, as discussed [at the reconstruction meeting](https://indico.cern.ch/event/1086705/contributions/4568518/attachments/2330839/3972063/RIG_timeCut_19_10_21.pdf).
The timing cut for our standalone topoclustering is controlled with the same CaloRec flags as for standard topoclustering, with the exception of the hardcoded `TimeCutUpperLimit` value (currently, `TimeCutUpperLimit` is also hardcoded wherever used, this might be harmonised by introducing a new CaloRec flag is a same value suits all clients).

The MR was tested with q431 and q221 on 40 events.
By default, as the timing cut is not enabled, the tau reconstruction output is unchanged.
When switching it on (`--preExec "RAWtoESD:from CaloRec.CaloTopoClusterFlags import jobproperties; jobproperties.CaloTopoClusterFlags.doTimeCut=True; jobproperties.CaloTopoClusterFlags.extendTimeCut=True; jobproperties.CaloTopoClusterFlags.useUpperLimitForTimeCut=True"`), we do see a difference for q431. For q221, as this is without pileup, the observed stability is rather encouraging.

q431 without timing cut:
```
     292.812 kb      111.966 kb        2.799 kb        2.615       40  CaloCalTopoClusters_links (CaloClusterCellLinkContainer_p1) [CaloTopo]
     302.836 kb      112.271 kb        2.807 kb        2.697       40  TauPi0Clusters_links (CaloClusterCellLinkContainer_p1) [tau]
     277.527 kb      133.037 kb        3.326 kb        2.086       40  TauPi0Clusters (DataVector<xAOD::CaloCluster_v1>) [tau]
    1760.537 kb      455.399 kb       11.385 kb        3.866       40  CaloCalFwdTopoTowers (DataVector<xAOD::CaloCluster_v1>) [CaloTopo]
    2710.928 kb     1074.640 kb       26.866 kb        2.523       40  CaloCalTopoClusters (DataVector<xAOD::CaloCluster_v1>) [CaloTopo]
     453.956 kb      105.116 kb        2.628 kb        4.319       40  TauJets (DataVector<xAOD::TauJet_v3>) [tau]
```

q431 with timing cut:
```
     233.249 kb       88.531 kb        2.213 kb        2.635       40  TauPi0Clusters_links (CaloClusterCellLinkContainer_p1) [tau]
     250.630 kb       97.291 kb        2.432 kb        2.576       40  CaloCalTopoClusters_links (CaloClusterCellLinkContainer_p1) [CaloTopo]
     224.163 kb      105.498 kb        2.637 kb        2.125       40  TauPi0Clusters (DataVector<xAOD::CaloCluster_v1>) [tau]
    1522.887 kb      398.415 kb        9.960 kb        3.822       40  CaloCalFwdTopoTowers (DataVector<xAOD::CaloCluster_v1>) [CaloTopo]
    1962.282 kb      774.669 kb       19.367 kb        2.533       40  CaloCalTopoClusters (DataVector<xAOD::CaloCluster_v1>) [CaloTopo]
     401.291 kb       92.599 kb        2.315 kb        4.334       40  TauJets (DataVector<xAOD::TauJet_v3>) [tau]
```

q221 without timing cut:
```
     268.911 kb      119.671 kb        2.992 kb        2.247       40  TauPi0Clusters (DataVector<xAOD::CaloCluster_v1>) [tau]
     373.886 kb      144.574 kb        3.614 kb        2.586       40  TauPi0Clusters_links (CaloClusterCellLinkContainer_p1) [tau]
     559.632 kb      229.120 kb        5.728 kb        2.443       40  CaloCalTopoClusters_links (CaloClusterCellLinkContainer_p1) [CaloTopo]
     649.238 kb      245.023 kb        6.126 kb        2.650       40  CaloCalTopoClusters (DataVector<xAOD::CaloCluster_v1>) [CaloTopo]
     518.233 kb      121.040 kb        3.026 kb        4.282       40  TauJets (DataVector<xAOD::TauJet_v3>) [tau]
```

q221 with timing cut:
```
     268.669 kb      119.530 kb        2.988 kb        2.248       40  TauPi0Clusters (DataVector<xAOD::CaloCluster_v1>) [tau]
     373.382 kb      144.688 kb        3.617 kb        2.581       40  TauPi0Clusters_links (CaloClusterCellLinkContainer_p1) [tau]
     558.644 kb      228.493 kb        5.712 kb        2.445       40  CaloCalTopoClusters_links (CaloClusterCellLinkContainer_p1) [CaloTopo]
     643.752 kb      242.926 kb        6.073 kb        2.650       40  CaloCalTopoClusters (DataVector<xAOD::CaloCluster_v1>) [CaloTopo]
     517.741 kb      120.767 kb        3.019 kb        4.287       40  TauJets (DataVector<xAOD::TauJet_v3>) [tau]
```

Too early to tell whether this is beneficial for taus :-), this will require in-depth studies based on true tau MC (gamma*->tautau and LLP->tau).

Cheers,
Bertrand

Expand  eFEX tau

See merge request atlas/athena!46592