Thomas Strebler authored 1 month ago and Duc Ta committed 1 month ago

Update startAtOriginalPerigee tracking flags to true (ATLASRECTS-8132)

Matous Vozak authored 2 months ago and Duc Ta committed 2 months ago

Apply 1 suggestion(s) to 1 file(s)

Co-authored-by: Johannes Junggeburth <johannes.josef.junggeburth@cern.ch>

Thomas Strebler authored 3 months ago and Jean-Baptiste De Vivie De Regie committed 3 months ago

Fix typo in tracking startAtOriginalPerigee flag name

Scott Snyder authored 3 months ago and Duc Ta committed 3 months ago

TrkDetDescrSvc: Fix out-of-bounds vector write.

reserve/resize confusion.
Fixes crash with -D_GLIBCXX_ASSERTIONS.

Scott Snyder authored 4 months ago and Jean-Baptiste De Vivie De Regie committed 4 months ago

TrkVertexSeedFinderUtils: Fix out-of-bounds vector access.

In these lines
```
        std::vector< std::pair< int, int> > idxprevious = (*idxs)[splt-1] ;
        offset = idxprevious[sz].second ;
```

we seem to want to refer to the last element in idxprevious.
But sz is the size of (*idxs)[split], so this can result in
an out-of-bounds access.  Changed to use back().
Also get rid of some needless vector copies.
Fixes crash when compiling with -D_GLIBCXX_ASSERTIONS.

Thomas Strebler authored 4 months ago and Jean-Baptiste De Vivie De Regie committed 4 months ago

Add protection against bad perigee in GlobalChi2Fitter (ATLASRECTS-8078)

Mark Sutton authored 4 months ago and Jiri Masik committed 4 months ago

Replace all the RegSelTool interface calls for the ID Trigger clients

The RegSelTool interface is being changed as discussed in !76173. This request replaces all the
ID Trigger related RegSelTool calls. The details for all the calls have been checked and the
output is identical both for simple Rois and composite Rois. The RawDataProviders
however, have NOT been checked since they so not run when running only over RDO, but code
itself for these calls is identical for that code for the clustring which has been validated.

This completes the the ID Trigger part of ATR-30360

Vakhtang Tsulaia authored 7 months ago and Tadej Novak committed 4 months ago

Allow Material Map configuration for Run<4

See merge request atlas/athena!72431

Vakhtang Tsulaia authored 1 year ago and Tadej Novak committed 4 months ago

replace flags.TrackOverlay with flags.TrackOverlay.ActiveConfig

See merge request !69611

Frank Winklmeier authored 1 year ago and Tadej Novak committed 4 months ago

Update for Run4 setup

See merge request atlas/athena!68601

Thomas Strebler authored 5 months ago and Duc Ta committed 5 months ago

Introduced Tracking.TRTStandalone.startArOriginalPerigee flag

Thomas Strebler authored 5 months ago and Duc Ta committed 5 months ago

Add printPrimaryConfig for tracking config

Kartik Deepak Bhide authored 5 months ago and Jean-Baptiste De Vivie De Regie committed 5 months ago

Apply 1 suggestion(s) to 1 file(s)

Co-authored-by: Thomas Strebler <thomas.strebler@cern.ch>

James Catmore authored 6 months ago and Ahmed Tarek committed 6 months ago

Downgrading WARNING to DEBUG in ImpactPoint3dEstimator, Adaptive(Multi)VertexFitter

ATLASRECTS-7525

The tools ImpactPoint3dEstimator and Adaptive(Multi)VertexFitter have been producing long-standing and long-ignored WARNING messages in the reconstruction, which (along with many others) are obfuscating the log files such we can't use WARNING messages for their intended purpose. This seems to be a particular issue when the tools are used in the tau domain.

There hasn't been much response on the JIRA so now I make the MR directly in the hope of provoking a response. Since there isn't much activity on this, I don't think this can be a very serious warning, in which case downgrading to DEBUG would be reasonable.

Stewart Martin-Haugh authored 6 months ago and Duc Ta committed 6 months ago

Always call context explicitly in TrackSummaryTool methods

Stewart Martin-Haugh authored 7 months ago and Duc Ta committed 7 months ago

Pass context to LorentzAngleTool

Stewart Martin-Haugh authored 7 months ago and Duc Ta committed 7 months ago

InnderDetector: Pass EventContext down

Passing event context to avoid calling currentContext function.
An Abstract interface IRIO_OnTrackCreator.h should be changed to pass
the event context, which resulted in change of many header files.

(It was observed that currentContext was frequently called by getCondData
which was frequently called by getLorentzShift and getTanLorentzAngle.
Hence the original aim is to pass EventContext to getCondData.)

Jiri Masik authored 7 months ago and Benjamin Philip Kerridge committed 7 months ago

clean impact settings from duplicate / dead flags

Ian Dyckes authored 7 months ago and Duc Ta committed 7 months ago

Addressing more MR comments: raise RunTimeError for bad flags, actually initialize all counters in .h

Thomas Strebler authored 7 months ago and Duc Ta committed 7 months ago

Separate basic track selections in track scoring tool

Teng Jian Khoo authored 7 months ago and Stefanie Morgenstern committed 7 months ago

Record the vertices sorted by the original sumpt for validation [ATR-29435]

Thomas Strebler authored 8 months ago and Duc Ta committed 8 months ago

Add protection against pathological fits in GlobalChi2Fitter.cxx

Thomas Strebler authored 8 months ago and Duc Ta committed 8 months ago

Tighten z safety check for pathological tracks (ATLASRECTS-8078)

Teng Jian Khoo authored 8 months ago and Duc Ta committed 8 months ago

Return intended value in JetRestrictedSumPtVertexWeightCalculator [ATR-29435]

Adam Edward Barton authored 8 months ago and Ahmed Tarek committed 8 months ago

Merge branch 'PhysVal_moveto_TH1D' into 'main'

use TH1D in PhysVal

See merge request atlas/athena!73103

(cherry picked from commit e434eed5)

a716b294 use TH2D in PhysVal

Teng Jian Khoo authored 9 months ago and Tim Adye committed 9 months ago

Use sumpt2 for jet-weighted vertex sorting

Edward Moyse authored 9 months ago and Duc Ta committed 9 months ago

TrkiPatFitter: Suppress warnings

Patrick Scholer authored 9 months ago and Ahmed Tarek committed 9 months ago

update tags for NSW cluster uncertainties in data

Thomas Strebler authored 9 months ago and Ahmed Tarek committed 9 months ago

Reduce verbosity in Tracking tools and algorithms

Vadim Kostyukhin authored 10 months ago and Duc Ta committed 10 months ago

Apply 1 suggestion(s) to 1 file(s)

Co-authored-by: Tim Adye <tim.adye@cern.ch>

Teng Jian Khoo authored 10 months ago and Andrea Coccaro committed 10 months ago

Use tracks in jets only for sumpt2-driven vertex sorting: ATR-29435

Thomas Strebler authored 10 months ago and Ahmed Tarek committed 10 months ago

Clean up legacy TrkExTools configs

Christos Anastopoulos authored 10 months ago and Duc Ta committed 10 months ago

TrackParticleCreatorTool: Reduce verbosity

Vadim Kostyukhin authored 10 months ago and Duc Ta committed 10 months ago

Add FPE protection

Additional protection against occasional FPE in error calculation

Thomas Strebler authored 10 months ago and Duc Ta committed 10 months ago

Clean up legacy DistributedKF config

Christos Anastopoulos authored 10 months ago and Duc Ta committed 10 months ago

Remove obsolete old style config for ATLASExtrapolationEngine

Christos Anastopoulos authored 10 months ago and Duc Ta committed 10 months ago

reduce a bit the ipatFitter verbosity

Christos Anastopoulos authored 10 months ago and Ahmed Tarek committed 10 months ago

GaussianSumFitter. Rm the fitter messages. tidy a bit the ones from Algs

Christos Anastopoulos authored 10 months ago and Ahmed Tarek committed 10 months ago

Try to simplify and reduce the init out put from TrackSummaryTool