Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Gaudi
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Gaudi
Gaudi
Commits
4ab43e5a
Commit
4ab43e5a
authored
1 year ago
by
Sebastien Ponce
Browse files
Options
Downloads
Patches
Plain Diff
Dropped useless (and problematic) operator== in HistoDef
parent
d121a4b4
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!1490
Fixed unsafe floating point comparisons
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
GaudiKernel/include/GaudiKernel/HistoDef.h
+0
-4
0 additions, 4 deletions
GaudiKernel/include/GaudiKernel/HistoDef.h
GaudiKernel/src/Lib/HistoDef.cpp
+0
-20
0 additions, 20 deletions
GaudiKernel/src/Lib/HistoDef.cpp
with
0 additions
and
24 deletions
GaudiKernel/include/GaudiKernel/HistoDef.h
+
0
−
4
View file @
4ab43e5a
...
...
@@ -88,10 +88,6 @@ namespace Gaudi {
// ========================================================================
/// ordering operator (to please BoundedVerifier)
friend
bool
operator
<
(
const
Histo1DDef
&
left
,
const
Histo1DDef
&
right
);
/// equality operator
friend
bool
operator
==
(
const
Histo1DDef
&
left
,
const
Histo1DDef
&
right
);
/// non-equality
friend
bool
operator
!=
(
const
Histo1DDef
&
left
,
const
Histo1DDef
&
right
);
// ========================================================================
/// the streamer operator for class Gaudi::Histo1DDef
friend
std
::
ostream
&
operator
<<
(
std
::
ostream
&
o
,
const
Gaudi
::
Histo1DDef
&
histo
);
...
...
This diff is collapsed.
Click to expand it.
GaudiKernel/src/Lib/HistoDef.cpp
+
0
−
20
View file @
4ab43e5a
...
...
@@ -60,26 +60,6 @@ namespace Gaudi {
return
std
::
tie
(
left
.
m_title
,
left
.
m_low
,
left
.
m_high
,
left
.
m_bins
)
<
std
::
tie
(
right
.
m_title
,
right
.
m_low
,
right
.
m_high
,
right
.
m_bins
);
}
// ============================================================================
// equality operator
// ============================================================================
#ifdef __ICC
// disable icc remark #1572: floating-point equality and inequality comparisons are unreliable
# pragma warning( push )
# pragma warning( disable : 1572 )
#endif
bool
operator
==
(
const
Gaudi
::
Histo1DDef
&
left
,
const
Gaudi
::
Histo1DDef
&
right
)
{
return
std
::
tie
(
left
.
m_title
,
left
.
m_low
,
left
.
m_high
,
left
.
m_bins
)
==
std
::
tie
(
right
.
m_title
,
right
.
m_low
,
right
.
m_high
,
right
.
m_bins
);
}
#ifdef __ICC
// re-enable icc remark #1572
# pragma warning( pop )
#endif
// ============================================================================
// non-equality
// ============================================================================
bool
operator
!=
(
const
Gaudi
::
Histo1DDef
&
left
,
const
Gaudi
::
Histo1DDef
&
right
)
{
return
!
(
left
==
right
);
}
// ============================================================================
// the streamer operator for class Gaudi::Histo1DDef
// ============================================================================
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment