Fix PluginService compilation with clang 6 (after !709)

GaudiPluginService/src/PluginServiceV2.cpp

@@ -39,7 +39,7 @@ namespace fs = std::filesystem;
 namespace fs = std::experimental::filesystem;
 #endif
 
-#if __GNUC__ >= 7
+#if __cplusplus >= 201703
 #include <string_view>
 #else
 #include <experimental/string_view>
@@ -59,19 +59,6 @@ namespace
 
 #include <algorithm>
 
-namespace
-{
-  inline std::string_view trim( std::string_view s )
-  {
-    const auto isspace = []( const char c ) -> bool { return std::isspace( c ); };
-
-    const auto p0 = std::find_if_not( begin( s ), end( s ), isspace ) - begin( s );
-    const auto p1 = std::find_if_not( rbegin( s ), rend( s ), isspace ) - rbegin( s );
-
-    return s.substr( p0, s.size() - p0 - p1 );
-  }
-}
-
 namespace
 {
   struct OldStyleCnv {
@@ -348,7 +335,7 @@ namespace Gaudi
           if ( pos )
             ++pos;
           else
-            pos = info.dli_fname;
+            return info.dli_fname;
           return pos;
 #else
           return "";

GaudiPluginService/tests/src/UseCasesLib.cpp

@@ -199,7 +199,7 @@ namespace Gaudi
 {
   namespace PluginService
   {
-    namespace v2
+    GAUDI_PLUGIN_SERVICE_V2_INLINE namespace v2
     {
       namespace Details
       {