Handle incompatible values for DataObjectHandleBase props (mr !650)

Closes #22


(cherry picked from commit 2106633f)

672c80ae Handle incompatible values for DataObjectHandleBase props

GaudiKernel/python/GaudiKernel/PropertyProxy.py

@@ -385,6 +385,9 @@ class DataObjectHandleBasePropertyProxy(PropertyProxy):
             return DataObjectHandleBase(value)
         elif isinstance(value, DataObjectHandleBase):
             return DataObjectHandleBase(value.__str__())
+        else:
+            raise ValueError("received an instance of %s, but %s expected" %
+                             (type(value), 'str or DataObjectHandleBase'))
 
 
 def PropertyProxyFactory(descr, doc, default):

GaudiKernel/tests/nose/test_Configurables.py

 # Prepare dummy configurables
 from GaudiKernel.Configurable import ConfigurableAlgorithm, Configurable
+from GaudiKernel.DataObjectHandleBase import DataObjectHandleBase
 
 
 class MyAlg(ConfigurableAlgorithm):
     __slots__ = {'Text': 'some text',
-                 'Int': 23}
+                 'Int': 23,
+                 'DataHandle': DataObjectHandleBase('Location')}
 
     def getDlls(self):
         return 'Dummy'
@@ -26,7 +28,10 @@ def test_correct():
     a = MyAlg()
     a.Int = 42
     a.Text = 'value'
-    assert a.getValuedProperties() == {'Int': 42, 'Text': 'value'}
+    a.DataHandle = '/Event/X'
+    assert a.getValuedProperties() == {
+        'Int': 42, 'Text': 'value',
+        'DataHandle': DataObjectHandleBase('/Event/X')}
 
 
 def test_invalid_value():
@@ -53,6 +58,17 @@ def test_invalid_value():
         assert False, 'ValueError exception expected, got %s' % type(
             x).__name__
 
+    try:
+        a.DataHandle = [123]
+        assert False, 'exception expected'
+    except AssertionError:
+        raise
+    except ValueError:
+        pass
+    except Exception, x:
+        assert False, 'ValueError exception expected, got %s' % type(
+            x).__name__
+
 
 def test_invalid_key():
     a = MyAlg()