scott snyder authored 1 year ago and Marco Clemencic committed 1 year ago

GaudiHandleBase has a virtual destructor which is declared with `=default'.
However. in C++20 mode, clang will then try to instiantiate all the virtual
functions for classes derived from this whenever the declarations
for those classes are seen.  The upshot is that then using Gaudi handles
with forward-declared classes doesn't work (even if the handle is only
declared in the header but not used in any way).

It turns out that we can avoid this behavior by changing the declaration
of the base class destructor to say `{}' instead of `=default'.
(This is perhaps a clang bug, but the standard is not very clear
on exactly when virtual members of the templated class are required
to be or not to be implicitly instantiated.)

See also ATLINFR-5113.

See merge request !1510

See merge request !1509

See merge request !1501

Closes #275

See merge request !1492

Closes #276

See merge request !1507

See merge request !1490

The current method of reading the input file leads to undefined behavior
errors in the ATLAS debug build. Use `std::stringstream` instead, which
is also supposedly faster.

Also rewrite `GetLastLineAndColumn` to not read the file twice.

See merge request !1502

See merge request !1500

See merge request !1496

Closes #270

See merge request !1495

See merge request !1494

Without `NamedRange_::operator==`, in the comparison between two
`NamedRange_` instances `nr1` and `nr2` C++20 would not be able to
choose between `(Range_&)nr1 == nr2` and `(Range_&)nr2 == nr1`.

Remove the property type added as a comment to the Conf.py files. It was
entirely cosmetic and often wrong (e.g. maps were annotated as `# list`).

Relates to issue #219.

- replace `.format` with f-strings
- replace `setattr` with direct `_properties` access in `merge`

More precisely, json data come from the JSONSink and this produces a list of non ordered items, one may call it a set.
Unfortunately JSON does not have such a concept so an ordered list is produced and the validator was naturally checking that the order was correct

See merge request !1483