Sebastien Ponce authored 1 year ago and Marco Clemencic committed 1 year ago

The problem was due to the use of deque, extremely slow for deleting when getting big.
The code was written that way supposing we would get ~100 entities (aka some human readable quantity), but we seem to reach > 100000...
So deque has been replaced by a map with entity's memory address as a key, and now the deletion is fast

Sebastien Ponce authored 2 years ago and Marco Clemencic committed 1 year ago

Also implemented a default, empty reset.

Sebastien Ponce authored 2 years ago and Marco Clemencic committed 1 year ago

The Sinks have now to implement a flush method, called both at the end (finalize) and regularly if auto flush is activated (via non 0 AutoFlushPeriod property).
Existing Sinks have been adapted.

Also added unit testing for BaseSink, both for the regular flushing and previous existing (and not yet tested) features.

- move Gaudi::Funtional to GaudiFunctional subdir
  - headers are now under "Gaudi/Functional"
  - legacy GaudiAlg corresponding header redirect to the new ones
- replace GaudiAlgorithm with Algorithm wherever possible in tests and
  utilities
- add Gaudi::Sequencer basic implementation to replace GaudiSequencer
- move GaudiAlg specific tests, examples, dictionaries and Python modules
  to GaudiAlg subdir
- add CMake option GAUDI_ENABLE_GAUDIALG to allow skipping GaudiAlg
  (default to true)
- minor fixes and clean ups

Edward Moyse authored 2 years ago and Marco Clemencic committed 2 years ago

This checks whether an explicitly named tool has had an property configured.
This is an attempt to detect a category of error where a tool is configured, but not added as a public tool.
In which case an unconfigured default tool is created, BUT with the expected non-default name, causing confusion.

Makes other sinks simpler and allows every sink to benefit from regexp based selection of entities

Fix a few conversion warnings that show up when compiling the code with
`-Wconversion`. The goal was not to make the code compile without
warnings, but rather reduce the "noise" as much as possible when
compiling client code against Gaudi headers.

!1164 introduced a regular clean up but the memory was not freed