Gitlab CI authored 6 years ago and Marco Clemencic committed 6 years ago

patch generated by standalone job

- remove virtual function destructor, qualify as final
- implement binary operator as friend functions
- implement less than using std::tie

   - prefer std::unique_ptr over raw pointer and explicit delete
   - declare implementations 'override' instead of 'virtual'
   - replace trivial constructors/destructors with = default
   - make sure const methods only return const access to members,
     add non-const reference only in non-const methods
   - prefer to contain vectors by value instead of (owned) pointer
     to avoid an extra indirection
   - make initialization of const objects constexpr
   - simplify constructors
   - add move constructor where appropriate
   - declare class which is contained by value in std::vector as 'final'
     and remove virtual destructor (inheriting from this is not used,
     and would have lead to slicing)
   - pass sink arguments by value and std::move them
   - prefer std::vector of std::list (as data member, when appropriate)
   - prefer STL algorithms over raw loops
   - prefer emplace_back over push_back
   - replace 0 by nullptr when appropriate
   - prefer std::copy_n over memcpy (compiler will use memcpy anyway)
   - prefer auto and range-based for loops
   - avoid comparing pointers to 0
   - prefer std::vector::clear over std::vector::erase( begin, end)

Note that the changes are such that all interfaces are source code
level compatible, i.e. one can recompile client code 'as-is' without
changes.

Alexander Mazurov authored 13 years ago and Marco Clemencic committed 13 years ago

http://savannah.cern.ch/patch/?4891

git-svn-id: svn+ssh://svn.cern.ch/reps/gaudi/Gaudi/trunk@6175 53ecefc3-a64d-0410-9bdf-b8581fa3287e

See https://twiki.cern.ch/twiki/bin/view/Gaudi/GaudiSVNRepository


git-svn-id: svn+ssh://svn.cern.ch/reps/gaudi/Gaudi/trunk@6014 53ecefc3-a64d-0410-9bdf-b8581fa3287e