- RootHistogramSink: avoid having a 'registry' for each instance,
  instead keep one shared constant global in an anonymous namespace
  so it is hidden from the linker
- JSONSink: use the fact that `ofstream` closes the corresponding file
  when going out of scope
- BaseSink: use `std::set` with dedicted comparison operator instead
  of `std::map` which saves a bit of memory
- MonitoringHub: avoid one level of indirection in the type erasure
  which will type-erased function arguments to be passed in registers
  instead of forcing them to be passed through main memory
- MonitoringHub: `m_typeIndex` is an invariant once constructed, and
  does not need a type-erased function to be determined 'on the fly'

Remove deprecated `OutStreamType` property from `ApplicationMgr` and
`MinimalEventLoopMgr`.

The current method of reading the input file leads to undefined behavior
errors in the ATLAS debug build. Use `std::stringstream` instead, which
is also supposedly faster.

Also rewrite `GetLastLineAndColumn` to not read the file twice.

Sebastien Ponce authored 1 year ago and Marco Clemencic committed 1 year ago

The problem was due to the use of deque, extremely slow for deleting when getting big.
The code was written that way supposing we would get ~100 entities (aka some human readable quantity), but we seem to reach > 100000...
So deque has been replaced by a map with entity's memory address as a key, and now the deletion is fast

Sebastien Ponce authored 2 years ago and Marco Clemencic committed 1 year ago

Also implemented a default, empty reset.

Sebastien Ponce authored 2 years ago and Marco Clemencic committed 1 year ago

The Sinks have now to implement a flush method, called both at the end (finalize) and regularly if auto flush is activated (via non 0 AutoFlushPeriod property).
Existing Sinks have been adapted.

Also added unit testing for BaseSink, both for the regular flushing and previous existing (and not yet tested) features.

- move Gaudi::Funtional to GaudiFunctional subdir
  - headers are now under "Gaudi/Functional"
  - legacy GaudiAlg corresponding header redirect to the new ones
- replace GaudiAlgorithm with Algorithm wherever possible in tests and
  utilities
- add Gaudi::Sequencer basic implementation to replace GaudiSequencer
- move GaudiAlg specific tests, examples, dictionaries and Python modules
  to GaudiAlg subdir
- add CMake option GAUDI_ENABLE_GAUDIALG to allow skipping GaudiAlg
  (default to true)
- minor fixes and clean ups

Edward Moyse authored 2 years ago and Marco Clemencic committed 2 years ago

This checks whether an explicitly named tool has had an property configured.
This is an attempt to detect a category of error where a tool is configured, but not added as a public tool.
In which case an unconfigured default tool is created, BUT with the expected non-default name, causing confusion.

Makes other sinks simpler and allows every sink to benefit from regexp based selection of entities