Marco Clemencic authored 4 years ago and Charles Leggett committed 4 years ago

- added minimal interface `Gaudi::Interfaces::IOptionsSvc`
- reimplemented `IJobOptionsSvc` methods using the new interface methods
  (`set`, `get` and `has`)
- deprecated `IJobOptionsSvc` methods

Gitlab CI authored 6 years ago and Marco Clemencic committed 6 years ago

patch generated by standalone job

- remove destructors qualified with 'override = default'
- prefer inheriting constructors

... plus some formatting tweaks,

also applied clang-format to all modified files

The == operator is not available for std::ostream.

   - pass sink arguments by value, and std::move them
   - prefer nullptr
   - avoid comparing pointers to 0

Prefer SmartIF over bare pointers to interfaces, and the subsequent explicit updating of the refCount

   - classify implementations as override instead of virtual
   - explicitly = delete non-implemented constructor/destructor/assignment-op
   - clean up constructors
   - do not duplicate keys of maps

   - replace invariant data members by static const
   - prefer return by value over IN-OUT parameter
   - remove unneeded #include files
   - replace trivial destructor with = default
   - combine m_log and m_logger into a single datastructure
   - consolidate (almost) copy and pasted code in lambda
   - prefer range-based for loop
   - prefer std::unique_ptr over raw pointer + explicit delete

  - simplify constructor
  - replace trivial destructor with = default
  - avoid an 'if' by realizing that std::string::substr(0, std::string::npos) just copies the string
  - remove virtual function implmentation that invokes the implementation of the direct ancestor

   - drop virtual on implementations already flagged override
   - flag more implementations as 'override' instead of 'virtual'
     (note: this is far from complete, and should be continued)
   - whilst doing the above, use covariant return types on 'clone' implementation
   - use std::unordered::map::{at,insert} in the implementation of Map
   - simplify 'sometimes owns' implementation of StreamLogger
   - remove unused member of FileMgr

   - use std::unique_ptr with special deleter to deal with the
     'sometimes' ownership

   - use cstdio, cstdarg instead of stdio.h, stdarg.h
   - use vnsprintf instead of vsprintf
   - add va_end after va_start