Thomas Cluzel authored 4 years ago and Marco Clemencic committed 4 years ago

see https://its.cern.ch/jira/browse/LBCOMP-23



Co-authored-by: Marco Clemencic <marco.clemencic@cern.ch>

Marco Clemencic authored 4 years ago and Charles Leggett committed 4 years ago

- added minimal interface `Gaudi::Interfaces::IOptionsSvc`
- reimplemented `IJobOptionsSvc` methods using the new interface methods
  (`set`, `get` and `has`)
- deprecated `IJobOptionsSvc` methods

* replace `std::set<std::unique_ptr<ParticleProperty>>` with
  `std::deque<ParticleProperty>` to keep owned, stable (as
  in 'remains at the same memory location') properties

Gitlab CI authored 6 years ago and Marco Clemencic committed 6 years ago

patch generated by standalone job

- and some minor format tweaking

- remove destructors qualified with 'override = default'
- prefer inheriting constructors

... plus some formatting tweaks,

and some related files

Prefer SmartIF over bare pointers to interfaces, and the subsequent explicit updating of the refCount

   - avoid repeated lookups
   - use more auto to simplify things
   - prefer boost::algorithm::trim_left_if over in-situ implementation

  - streamline constructors
  - prefer std::unique_ptr over raw pointer with new/delete
  - use auto / range-based loops to reduce "noise"
  - use nullptr instead of NULL
  - use 'override' instead of 'virtual' in derived classes
  - define a type for pointer to function to reduce "noise"

  - replace 'if (s.substr(a,b) = "ccc")' with 'if (s.compare(a,c,"ccc")==0)'
    which avoids creating a temporary string that is immediately thrown away again
  - used std::stoi(s) instead of ::atoi(s.c_str()), ditto for std::stod
  - replace s.substr(a,s.length()-a) and s.substr(a,s.length()) with s.substr(a)

From: Marco Clemencic <marco.clemencic@cern.ch>


git-svn-id: svn+ssh://svn.cern.ch/reps/gaudi/Gaudi/trunk@7502 53ecefc3-a64d-0410-9bdf-b8581fa3287e