More precisely, json data come from the JSONSink and this produces a list of non ordered items, one may call it a set.
Unfortunately JSON does not have such a concept so an ordered list is produced and the validator was naturally checking that the order was correct

See merge request !1483

See merge request !1415

Closes #265

See merge request !1468

Closes #273

See merge request !1489

See merge request !1488

See merge request !1486

See merge request !1485

See merge request !1484

See merge request !1491

See merge request !1477

Sebastien Ponce authored 1 year ago and Marco Clemencic committed 1 year ago

The problem was due to the use of deque, extremely slow for deleting when getting big.
The code was written that way supposing we would get ~100 entities (aka some human readable quantity), but we seem to reach > 100000...
So deque has been replaced by a map with entity's memory address as a key, and now the deletion is fast

Sebastien Ponce authored 1 year ago and Marco Clemencic committed 1 year ago

use std::promise/future instead of misusing std::condition_variable

Replicated from identical commit in LHCb FSRSink.cpp file (lhcb/LHCb@e4b7fdf9)

Sebastien Ponce authored 2 years ago and Marco Clemencic committed 1 year ago

In particuler :
  - made it a free function
  - fixed bad usage of move semantic in favor of references

Sebastien Ponce authored 2 years ago and Marco Clemencic committed 1 year ago

Also implemented a default, empty reset.

Sebastien Ponce authored 2 years ago and Marco Clemencic committed 1 year ago

The Sinks have now to implement a flush method, called both at the end (finalize) and regularly if auto flush is activated (via non 0 AutoFlushPeriod property).
Existing Sinks have been adapted.

Also added unit testing for BaseSink, both for the regular flushing and previous existing (and not yet tested) features.