Fix the cleanup function and extend the test to `dict` and `list`
proprties. Also migrate to `pytest` fixtures and exception handling.

scott snyder authored 1 year ago and Marco Clemencic committed 1 year ago

GaudiHandleBase has a virtual destructor which is declared with `=default'.
However. in C++20 mode, clang will then try to instiantiate all the virtual
functions for classes derived from this whenever the declarations
for those classes are seen.  The upshot is that then using Gaudi handles
with forward-declared classes doesn't work (even if the handle is only
declared in the header but not used in any way).

It turns out that we can avoid this behavior by changing the declaration
of the base class destructor to say `{}' instead of `=default'.
(This is perhaps a clang bug, but the standard is not very clear
on exactly when virtual members of the templated class are required
to be or not to be implicitly instantiated.)

See also ATLINFR-5113.

Without `NamedRange_::operator==`, in the comparison between two
`NamedRange_` instances `nr1` and `nr2` C++20 would not be able to
choose between `(Range_&)nr1 == nr2` and `(Range_&)nr2 == nr1`.

Remove the property type added as a comment to the Conf.py files. It was
entirely cosmetic and often wrong (e.g. maps were annotated as `# list`).

Relates to issue #219.

Sebastien Ponce authored 1 year ago and Marco Clemencic committed 1 year ago

The problem was due to the use of deque, extremely slow for deleting when getting big.
The code was written that way supposing we would get ~100 entities (aka some human readable quantity), but we seem to reach > 100000...
So deque has been replaced by a map with entity's memory address as a key, and now the deletion is fast

Sebastien Ponce authored 1 year ago and Marco Clemencic committed 1 year ago

use std::promise/future instead of misusing std::condition_variable

Replicated from identical commit in LHCb FSRSink.cpp file (lhcb/LHCb@e4b7fdf9)

Sebastien Ponce authored 2 years ago and Marco Clemencic committed 1 year ago

In particuler :
  - made it a free function
  - fixed bad usage of move semantic in favor of references

Sebastien Ponce authored 2 years ago and Marco Clemencic committed 1 year ago

Also implemented a default, empty reset.

Sebastien Ponce authored 2 years ago and Marco Clemencic committed 1 year ago

The Sinks have now to implement a flush method, called both at the end (finalize) and regularly if auto flush is activated (via non 0 AutoFlushPeriod property).
Existing Sinks have been adapted.

Also added unit testing for BaseSink, both for the regular flushing and previous existing (and not yet tested) features.

- move Gaudi::Funtional to GaudiFunctional subdir
  - headers are now under "Gaudi/Functional"
  - legacy GaudiAlg corresponding header redirect to the new ones
- replace GaudiAlgorithm with Algorithm wherever possible in tests and
  utilities
- add Gaudi::Sequencer basic implementation to replace GaudiSequencer
- move GaudiAlg specific tests, examples, dictionaries and Python modules
  to GaudiAlg subdir
- add CMake option GAUDI_ENABLE_GAUDIALG to allow skipping GaudiAlg
  (default to true)
- minor fixes and clean ups

only showing on el9 gcc12

adding a test to make sure we compile an instantiation of it