Thomas Cluzel authored 4 years ago and Marco Clemencic committed 4 years ago

see https://its.cern.ch/jira/browse/LBCOMP-23



Co-authored-by: Marco Clemencic <marco.clemencic@cern.ch>

Gitlab CI authored 5 years ago and Gerhard Raven committed 5 years ago

patch generated by https://gitlab.cern.ch/gaudi/Gaudi/-/jobs/6508952

The error reporting policy in ATLAS has changed making this auditor
obsolete.

Gitlab CI authored 6 years ago and Marco Clemencic committed 6 years ago

patch generated by standalone job

The updatehandler can either be anything which satisfies
the `void(PropertyBase&)` signature, or a member function
with the signature `void()` or `void(PropertyBase&)`.
In addition, an additonal argument can be passed which specifies
whether or not the provided handel should be invoked immediately.
Default is to _not_ invoke it immediately.

- remove destructors qualified with 'override = default'
- prefer inheriting constructors

... plus some formatting tweaks,

Replace code that relies on implicit StatusCode bool/long conversions.

https://coverity.cern.ch/reports.htm#v13572/p10041/fileInstanceId=759345761&defectInstanceId=394525640&mergedDefectId=82290

also applied clang-format to all modified files

and some related files

Prefer SmartIF over bare pointers to interfaces, and the subsequent explicit updating of the refCount

  - use explict bool conversion instead of .isValid()
  - add SmartIF::as<IFace>(), to return a SmartIF to an alternate
    interface -- which (together with move) encourages the use of auto
  - add ServiceManager::service<IFace>() which return SmartIF<IFace> which encourages
    the use of auto

And add a few other C++11 modernizations (eg. prefer STL over raw loop)