Sebastien Ponce authored 2 years ago and Marco Clemencic committed 1 year ago

The Sinks have now to implement a flush method, called both at the end (finalize) and regularly if auto flush is activated (via non 0 AutoFlushPeriod property).
Existing Sinks have been adapted.

Also added unit testing for BaseSink, both for the regular flushing and previous existing (and not yet tested) features.

- move Gaudi::Funtional to GaudiFunctional subdir
  - headers are now under "Gaudi/Functional"
  - legacy GaudiAlg corresponding header redirect to the new ones
- replace GaudiAlgorithm with Algorithm wherever possible in tests and
  utilities
- add Gaudi::Sequencer basic implementation to replace GaudiSequencer
- move GaudiAlg specific tests, examples, dictionaries and Python modules
  to GaudiAlg subdir
- add CMake option GAUDI_ENABLE_GAUDIALG to allow skipping GaudiAlg
  (default to true)
- minor fixes and clean ups

Makes other sinks simpler and allows every sink to benefit from regexp based selection of entities

Namely m_header, m_format1, m_format2, m_useEffFormat, m_printEmptyCounters, m_statEntityList

This should have in principle no consequences, but most tests will
actually fail as the properties values are printed to the output, and
these will be missing now

Note that MonitoringHub is now Gaudi::Monitoring::Hub.

Counters are now serialized in json and sent to a MessageSvcSink for printing.
This should be kind of backward compatible with current printing except that the Counter order may change.

The CounterHolder wrapper, now useless, has been dropped and counters register directly to the Monitoring::Hub
Note that his had the consequence that the Counters method of the python interface had to be dropped.
It does not seem to be used, but in case it would be needed, it can be implemented if we add a dedicated method to list counters of a given component to the Monitoringi::Hub

Marco Clemencic authored 4 years ago and Charles Leggett committed 4 years ago

- added minimal interface `Gaudi::Interfaces::IOptionsSvc`
- reimplemented `IJobOptionsSvc` methods using the new interface methods
  (`set`, `get` and `has`)
- deprecated `IJobOptionsSvc` methods

still use the old way for a few special cases or if GAUDIRUN_USE_OLDINIT
is set

preserve thread safety and fix the regression reported in GAUDI-1319

having sysExecute() and sysExecute(EventContext) causes "overloaded virtual" compiler
warnings, and we don't actually need the one without an EventContext.

Updated reference files for tests

All event state information removed from Algorithm base class
(m_filterPassed, m_isExecuted) as it will cause difficulties with
re-entrant Algorithms.

event success/fail flag removed from EventContext

These flags are moved to be under control of a new service, the
AlgExecStateSvc, which keeps track of the execution state of all
Algorithms, and the Event as a whole.

Algorithm status kept in a new class AlgExecState which has
     bool m_filterPassed;
     bool m_isExecuted;
     StatusCode m_execStatus;

AlgExecStateSvc holds an AlgExecState for each Algorithm in each Event
Slot, as well as an overall EventStatus for each EventSlot, which can be one of
   Invalid = 0,
   Success = 1,
   AlgFail = 2,
   AlgStall = 3,
   Other = 4

Algorithms add themselves to the AlgExecStateSvc upon initialization, but the
Service's initialization of  the data structures is deferred until the first
time AlgExecStateSvc::reset() is called, at which point it's probably safe to figure out
if there's a WhiteBoard, and the number of slots to allocate.

 Also added an EventContext object to the MinimalEventLoopMgr,
 so that serial/concurrent behaviour is similar.

Concurrent queries to the AlgExecStateSvc must contain the EventContext, so
the correct EventSlot can be determined. Serial access is via methods that
don't have the EventContext as a parameter. For access from Algorithm
base class (eg from setFilterPassed, isExecuted, etc), if the EventContext
ptr (m_event_context) in the Algorithm is null, we assume we're running
serially.

modified:   GaudiAlg/src/lib/GaudiSequencer.cpp
modified:   GaudiAlg/src/lib/Sequencer.cpp
modified:   GaudiCoreSvc/CMakeLists.txt
new file:   GaudiCoreSvc/src/AlgExecStateSvc/AlgExecStateSvc.cpp
new file:   GaudiCoreSvc/src/AlgExecStateSvc/AlgExecStateSvc.h
modified:   GaudiCoreSvc/src/IncidentSvc/DataOnDemandSvc.cpp
modified:   GaudiExamples/options/ROOT_IO/Write.py
modified:   GaudiExamples/tests/qmtest/gaudiexamples.qms/jira.qms/gaudi_1174.qmt
modified:   GaudiExamples/tests/qmtest/refs/ColorMsg.ref
modified:   GaudiExamples/tests/qmtest/refs/History.ref
modified:   GaudiExamples/tests/qmtest/refs/MetaDataSvc.ref
modified:   GaudiExamples/tests/qmtest/refs/ROOT_IO/Read.ref
modified:   GaudiExamples/tests/qmtest/refs/ROOT_IO/Write.ref
modified:   GaudiExamples/tests/qmtest/refs/RandomNumber.ref
modified:   GaudiExamples/tests/qmtest/refs/conditional_output/write.ref
modified:   GaudiExamples/tests/qmtest/refs/jira/gaudi_971.ref
modified:   GaudiHive/GaudiHive/HiveEventLoopMgr.h
modified:   GaudiHive/GaudiHive/HiveSlimEventLoopMgr.h
modified:   GaudiHive/options/BrunelScenarioForwardScheduler.py
modified:   GaudiHive/options/ForwardSchedulerStall.py
modified:   GaudiHive/src/AlgResourcePool.cpp
modified:   GaudiHive/src/AlgoExecutionTask.cpp
modified:   GaudiHive/src/AlgoExecutionTask.h
modified:   GaudiHive/src/ForwardSchedulerSvc.cpp
modified:   GaudiHive/src/ForwardSchedulerSvc.h
modified:   GaudiHive/src/HiveEventLoopMgr.cpp
modified:   GaudiHive/src/HiveSlimEventLoopMgr.cpp
modified:   GaudiHive/src/ParallelSequentialSchedulerSvc.cpp
modified:   GaudiHive/src/ParallelSequentialSchedulerSvc.h
modified:   GaudiHive/src/RoundRobinSchedulerSvc.cpp
modified:   GaudiHive/src/RoundRobinSchedulerSvc.h
modified:   GaudiHive/src/SequentialSchedulerSvc.cpp
modified:   GaudiHive/src/SequentialSchedulerSvc.h
modified:   GaudiKernel/GaudiKernel/Algorithm.h
modified:   GaudiKernel/GaudiKernel/EventContext.h
new file:   GaudiKernel/GaudiKernel/IAlgExecStateSvc.h
modified:   GaudiKernel/GaudiKernel/IAlgorithm.h
modified:   GaudiKernel/GaudiKernel/MinimalEventLoopMgr.h
modified:   GaudiKernel/src/Lib/Algorithm.cpp
modified:   GaudiKernel/src/Lib/MinimalEventLoopMgr.cpp
modified:   GaudiSvc/options/Test.opts
modified:   GaudiSvc/tests/qmtest/refs/Test.ref

From: Marco Clemencic <marco.clemencic@cern.ch>


git-svn-id: svn+ssh://svn.cern.ch/reps/gaudi/Gaudi/trunk@7353 53ecefc3-a64d-0410-9bdf-b8581fa3287e

Christopher Rob Jones authored 11 years ago and Marco Clemencic committed 11 years ago

From: Christopher R Jones <christopher.rob.jones@cern.ch>


git-svn-id: svn+ssh://svn.cern.ch/reps/gaudi/Gaudi/trunk@7351 53ecefc3-a64d-0410-9bdf-b8581fa3287e

* removed obsolete test runner scripts
* moved python scripts 'scripts'
* moved reference files to 'tests/qmtest/refs'
* moved input.hbook to 'tests/data'

From: Marco Clemencic <marco.clemencic@cern.ch>


git-svn-id: svn+ssh://svn.cern.ch/reps/gaudi/Gaudi/branches/GAUDI/GAUDI_newpack@6741 53ecefc3-a64d-0410-9bdf-b8581fa3287e

https://savannah.cern.ch/bugs/?85377

From: Marco Clemencic <marco.clemencic@cern.ch>


git-svn-id: svn+ssh://svn.cern.ch/reps/gaudi/Gaudi/trunk@6706 53ecefc3-a64d-0410-9bdf-b8581fa3287e

The message reporting the value of the  property CnvServices
is now DEBUG (instead of INFO).

git-svn-id: svn+ssh://svn.cern.ch/reps/gaudi/Gaudi/branches/GAUDI/GAUDI_nativedep@6445 53ecefc3-a64d-0410-9bdf-b8581fa3287e

Modified MyTrack and MyVertex to print the count of lost instances
only if different from 0.

See https://twiki.cern.ch/twiki/bin/view/Gaudi/GaudiSVNRepository


git-svn-id: svn+ssh://svn.cern.ch/reps/gaudi/Gaudi/trunk@6014 53ecefc3-a64d-0410-9bdf-b8581fa3287e