Sebastien Ponce authored 2 years ago and Marco Clemencic committed 1 year ago

Also implemented a default, empty reset.

Chris Burr authored 2 years ago and Marco Clemencic committed 2 years ago

Co-authored-by: Nicole Skidmore <nicola.skidmore@cern.ch>
Co-authored-by: Marco Clemencic <marco.clemencic@cern.ch>

because with Boost 1.81 using directly Gaudi::Property<std::string> is
ambiguous

This is done by only updating the potentially existing file when writing and droping the file at initialization to not mix data from 2 rounds.
There is no thread safety issue for now as we write in the stop method

And simplified the existing RootSink implementation accordingly

Makes other sinks simpler and allows every sink to benefit from regexp based selection of entities

When the static function TH1::SetDefaultSumw2 had been called (passing true), `Sumw2(true)` is automatically
called by the constructor of TProfile. This is a problem because in the profiles in Gaudi::Accumulators we do
not keep track of the sum of squares of weights and consequently don't set fBinSumw2 of the TProfile, which in
turn leads to a self-inconsistent TProfile object. The "fix" is to disable sum of squares explicitly.

Sebastien Ponce authored 2 years ago and Marco Clemencic committed 2 years ago

Separated RootHistogramSinkBase from RootHistogramSink so that this part is reusable for other sinks

Before this change, RootHistogramSink always puts a histogram
in a top level directory named according to the component name.
This change allows a histogram to be saved in a custom directory
by naming it with a leading slash. In that case, the component
name is ignored.

The levels are basically the number of slashes in a path in the store.
But EvtStoreSvc was not taking into account the slashes in the rootName, thus having lower numbers.

StatusCodeSvc has been deprecated (and non-functional) since Gaudi
%v36r0. Delete the service and its interface.

This number was wrongly computed by ROOT and needed to be overwritten
manually. This bit was missing in the original Sink.

using directories named after the component owning the histograms

This allows to remove entities from the hub (and thus from the sinks in
the back) and thus allows to use entities in temporary objects, and not
only in Tool/algorithms.

The counter part is that BufferableCounters are no more movable,
although I doubt anyone really want to move a counter. It only has the
consequence that you can hardly have vectors of counters, but arrays or
deques are still fine

2 main points :
  - the ptr internal data of Entity is now private
  - the string type of some accumulators (counters and histograms
    mostly) has been extended with an extra ':' and a string after it
    describing the precision of the internal data, using the typeid of
    the type that should be used when deserializing it from json

Which needs to be done carefully in case of some compiler/platform
combinations.

Thomas Cluzel authored 4 years ago and Marco Clemencic committed 4 years ago

see https://its.cern.ch/jira/browse/LBCOMP-23



Co-authored-by: Marco Clemencic <marco.clemencic@cern.ch>

Gitlab CI authored 4 years ago and Sebastien Ponce committed 4 years ago

patch generated by https://gitlab.cern.ch/gaudi/Gaudi/-/jobs/10130864