- Mar 16, 2018
-
-
Marco Clemencic authored
-
Martin Errenst authored
deReg deleted the object it is deRegistering, but the main purpose of this method is to undo the regiser process, which essentially means to just give up ownership without deletion!
-
- Mar 15, 2018
-
-
Marco Clemencic authored
Use thread-local copies of the ToolHandleArray
-
Marco Clemencic authored
-
-
Marco Clemencic authored
If a property contains `[[deprecated]]` in its doc string, print a deprecation warning on setting the property value.
-
Marco Clemencic authored
-
Marco Clemencic authored
-
-
Marco Clemencic authored
-
Marco Clemencic authored
-
Marco Clemencic authored
-
Marco Clemencic authored
-
-
Marco Clemencic authored
-
- Mar 14, 2018
-
-
Frank Winklmeier authored
If a property contains '[[deprecated]]' in its doc string, print a deprecation warning on setting the property value.
-
- Mar 13, 2018
-
-
scott snyder authored
ToolHandle is not thread-safe. In order to be able to run thread initialization in parallel, we need to make thread-local copies of the ToolHandleArray. Needed to allow running part of the G4 initialization in parallel for the ATLAS simulation. Makes a significant difference on many-core machines like KNL.
-
Frank Winklmeier authored
Coverity claims: error #2443: defaulted default constructor cannot be constexpr because the corresponding implicitly declared default constructor would not be constexpr constexpr StatusCode() = default; Independent of that there is little use of declaring the default constructor as constexpr as it is calling the non-constexpr default_category().
-
- Mar 12, 2018
-
-
Martin Errenst authored
The lambda in deReg( TObject* ) tried to access vhid->at(0) after a check for vhid->size() == 0. This resulted in a certain crash. I've reorganized the function to delete the vector of THistIDs when vhid->size() is 1 (not 0). There is also a new test case that registers and deregisters a single histogram. Apply formatting
-
- Mar 08, 2018
-
-
Martin Errenst authored
Add legacy methods for regGraph and regTree Migrating the Athena in these cases would be possible, but not very clean. This is why I decided to favor a consistent interface (with similar methods for Hists, Trees and Graphs), opposed to only providing unique_ptr methods. It would be good if future THistSvc clients would pick up the new methods and old methods would be migrated over time.
-
Hadrien Benjamin Grasland authored
-
- Mar 05, 2018
-
-
Martin Errenst authored
The previous changes in the interface were to drastic. They would have required too many changes for a service that is likely to be rewritten for ROOT7 within the next 2 years anyway. (2018, 2019) So here we offer a deprecated version without proper ownership management that still works the same in the new implementation. Fix wrong naming in ITHistSvcMT Update ITHistSvc for better legacy support There is now a deprecated regHist method with the old interface. Since we don't want to spam too much during the Athena build, the new regHist method, that transfers ownership, can also return a raw pointer directly. This supports a very common use case in Athena, where the registered histogram is used afterwards. The migration is likely to be scriptable in this case. Adapt new interface in THistSvc.h Fix small typo in THistSvc.h Update InterfaceID version in ITHistSvc Fix wrong default parameter in interface Fit implementation to new interface Fix THistSvc tests and ref files Remove TODOs that are not relevant yet Apply formatting from CI artifacts Update IHistSvc to be more consistent Add THistSvc tests and fix reference The write tests now also contains tests for the new regHist and regShared/getShared methods. Update dbg reference as well Apply formatting patch Remove deprecation attribute from ITHistSvc This would introduce an additional warning for every Gaudi build, while the intention is to discourage the use of its implementation in THistSvc.h. The interface method is still marked as deprecated through a doxygen comment. Add accidentally deleated return type to regHist Comment out deprecation attribute in THistSvc.h Initialize pointer in THistSvc tests Add GAUDI_API back to ITHistSvc Initialize all pointers in THistSvc Apply clang formatting patch from CI Hide deprecation warning behind ATLAS includeguard Let the thistwrite ignore specific file sizes Revert sortgroup regex The previous change did not cover all of the necessary cases and was wrong. Apply formatting artifacts Change test regex also for reading
-
- Feb 28, 2018
-
-
Marco Clemencic authored
-
Marco Clemencic authored
-
- Feb 26, 2018
-
-
cherry-pick of !599
-
- Feb 22, 2018
-
-
Marco Clemencic authored
-
-
- Feb 20, 2018
-
-
Frank Winklmeier authored
gaudi_add_compile_test can be used to add tests that check for the existence of (expected) compilation failures. Use this to implement a unit test to check for StatusCode comilation failures.
-
- Feb 19, 2018
-
-
Marco Clemencic authored
Closes #14
-
- Feb 18, 2018
-
-
Illya Shapoval authored
-
- Feb 15, 2018
-
-
Charles Leggett authored
See merge request !546
-
- Feb 14, 2018
-
-
Marco Clemencic authored
add support for categories (domains) to `StatusCode by using typed enums and ideas from `std::error_code`.
-
Marco Clemencic authored
-
Marco Clemencic authored
-
Marco Clemencic authored
-
Charles Leggett authored
See merge request !581
-
Charles Leggett authored
See merge request !579
-
Charles Leggett authored
See merge request !578
-
- Feb 13, 2018
-
-
Charles Leggett authored
See merge request !572
-
Charles Leggett authored
See merge request !509
-