Follow-up from "Use unique pointers for EventContexts": convert scheduler interface to use unique pointers only
The following discussion from !732 (merged) should be addressed:
-
@clemenci started a discussion: (+2 comments)
This worries me a bit... you should move the
unique_ptr
intom_finishedEvents
, andpopFinishedEvent
should be refactored to returnunique_ptr
(at the moment it returns aStatusCode
which value is equivalent to check if the returned pointer is valid or not, and used only in a print out... and basically ignored).It may also be that
tbb::concurrent_bounded_queue
cannot holdunique_ptr
s (but I doubt it) in which case you can forget about my comment.