AlgExecStateSvc: Remove a fatal message and minor cleanups

Remove the fatal message in checkInit. It already throws an exception and this way we can leave it up to the caller to print an appropriate message.

Some other changes:

• std::map -> std::unordered_map
• Add a few const
• Use ConcurrencyFlags to retrieve the number of slots instead of trying to find the IHiveWhiteBoard.

cc @rbielski

changed the description

added 10 commits

• d7eb715e...3f9b70e4 - 9 commits from branch gaudi:master
• b8d2f0a4 - AlgExecStateSvc: Remove a fatal message and minor cleanups

Compare with previous version

changed milestone to %v33r1

assigned to @clemenci

added lhcb-gaudi-head label

• [2020-02-12 00:04] Validation started with lhcb-gaudi-head#2529
• [2020-02-13 00:05] Validation started with lhcb-gaudi-head#2530
• [2020-02-14 00:04] Validation started with lhcb-gaudi-head#2531
• [2020-02-14 13:58] Validation started with lhcb-gaudi-head#2532
• [2020-02-15 00:08] Validation started with lhcb-gaudi-head#2533
• [2020-02-16 00:04] Validation started with lhcb-gaudi-head#2534
• [2020-02-17 00:07] Validation started with lhcb-gaudi-head#2535
• [2020-02-18 00:07] Validation started with lhcb-gaudi-head#2536
• [2020-02-19 00:05] Validation started with lhcb-gaudi-head#2537
• [2020-02-20 00:08] Validation started with lhcb-gaudi-head#2538
• [2020-02-23 00:04] Validation started with lhcb-gaudi-head#2539
• [2020-02-25 00:05] Validation started with lhcb-gaudi-head#2540

approved this merge request

merged

mentioned in commit 508da91e