Skip to content
Snippets Groups Projects

Use find_if instead of for+break and fix possible segfault

Closed Use find_if instead of for+break and fix possible segfault
clemenci/Gaudi:142-improve-ToolVisitorTest-logic into master
2 unresolved threads
Closed Marco Clemencic requested to merge clemenci/Gaudi:142-improve-ToolVisitorTest-logic into master
2 unresolved threads

Closes #142 (closed)

Merge request reports

Pipeline #2012745 passed

Stage: build
    Stage: test

      Pipeline passed for cda96b72 on clemenci:142-improve-ToolVisitorTest-logic

      Closed by Marco ClemencicMarco Clemencic 4 years ago (Oct 15, 2020 9:57am UTC)

      Loading

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      GaudiExamples/src/ToolVisitorTest/ToolVisitorTestLib.cpp
      42 42 pos = pos2;
      43 43 }
      44 44 if ( pos != std::string::npos ) {
      45 45 return std::string( &( full_name.c_str()[pos + 1] ), full_name.size() - pos - 1 );
      • G
        Gerhard Raven @graven ·
        Developer

        This looks like a very complicated way of writing:

        Suggested change
        45 return std::string( &( full_name.c_str()[pos + 1] ), full_name.size() - pos - 1 );
        45 return full_name.substr(pos+1);
      • Please register or sign in to reply
    • Gerhard Raven @graven started a thread on the diff
      • GaudiExamples/src/ToolVisitorTest/ToolVisitorTestLib.cpp
      29 29 if ( !condition ) {
      30 30 std::stringstream msg;
      31 31 msg << "Conditoin Failed: " << file_name << ":" << line_no << " " << condition_string;
      32 32 throw std::runtime_error( msg.str() );
      • G
        Gerhard Raven @graven ·
        Developer
        Suggested change
        30 std::stringstream msg;
        31 msg << "Conditoin Failed: " << file_name << ":" << line_no << " " << condition_string;
        32 throw std::runtime_error( msg.str() );
        30 throw std::runtime_error( fmt::format( "Condition Failed: {}:{} {}",file_name,line_no,condition_string));

        with of course #include "fmt/format.h" somewhere at the start of the file...

      • Please register or sign in to reply
    • L
      Software for LHCb @lhcbsoft ·
      Edited by Software for LHCb
    • C
      Marco Clemencic @clemenci ·
      Author Owner

      Close in favour of !1135 (merged)

    • Marco Clemencic closed

      closed

      • Please register or sign in to reply