IncidentSvc: fix ever-growing incident map

The map used for the storage of the asynchronous incidents was never cleared during the job and each new EventContext added a new entry into the map that only got cleared during finalize() (see !758 (merged)). Change the storage to be slot-specific and clear the list of incidents when the event changes for a given slot. Thanks to @rbielski for reporting this as part of https://its.cern.ch/jira/browse/ATR-22070.

In addition a few unrelated cleanups (in a separate commit):

• Make IncidentProcAlg a re-entrant algorithm.
• Fix AsyncIncidents example job options.
• Minor code cleanups in incident handling.

added performance label

On further reflection, I realize this solution is not good enough in call cases. If a job does not schedule a IncidentProcAlg and hence popIncidents is never called we are back to the original problem. It would be better if the IncidentSvc would have a built-in garbage collector where it disposes of incidents that are obsolete. However, for this it would have to gain knowledge about which EventContexts are still in flight. This needs some further thought and I would be happy for any feedback...

marked as a Work In Progress

added 2 commits

• 0017a441 - Minor changes to IncidentProcAlg
• 7911414c - IncidentSvc: clear incident map

Compare with previous version

changed the description

unmarked as a Work In Progress

@clemenci, any chance we could get this into %v35r1?

changed milestone to %v35r1

added lhcb-gaudi-head label

assigned to @clemenci

added 1 commit

• a94ad7b8 - Re-enabled the installation of the PartPropSvc auxiliary files.

Compare with previous version

added 35 commits

• a94ad7b8...fb3fd1e3 - 33 commits from branch gaudi:master
• e201e67e - Minor changes to IncidentProcAlg
• 95f8a0af - IncidentSvc: clear incident map

Compare with previous version

• [2021-01-21 00:08] Validation started with lhcb-gaudi-head#2832
• [2021-01-21 08:28] Validation started with lhcb-run2-gaudi-head#52
• [2021-01-22 00:05] Validation started with lhcb-gaudi-head#2833
• [2021-01-22 00:24] Validation started with lhcb-run2-gaudi-head#53
• [2021-01-23 00:08] Validation started with lhcb-gaudi-head#2834
• [2021-01-23 00:42] Validation started with lhcb-run2-gaudi-head#54
• [2021-01-24 00:04] Validation started with lhcb-gaudi-head#2835
• [2021-01-26 00:05] Validation started with lhcb-gaudi-head#2836
• [2021-01-27 00:03] Validation started with lhcb-gaudi-head#2837

added 7 commits

• 95f8a0af...d672398c - 5 commits from branch gaudi:master
• 0004f4da - Minor changes to IncidentProcAlg
• faba70fc - IncidentSvc: clear incident map

Compare with previous version

approved this merge request

resolved all threads

enabled an automatic merge when the pipeline for faba70fc succeeds

merged

mentioned in commit 66b9e966

mentioned in merge request !1238 (merged)

mentioned in commit 3a3283f6