Property: Catch all parsing errors

Property::fromString was only catching std::invalid_argument exceptions. However, there can be other exceptions thrown by the parser (e.g. from boost::spirit) that were not being filtered. As those exceptions were only caught higher up they lead to very unhelpful error messages. Change the code to catch all std::exceptions. In addition:

• Re-throw the exception as Gaudi::Exception.
• Improve the diagnostics to contain the property name and owner type.
• Add "WARNING/FATAL" keywords to the stderr message.
• Add test case to PropertyAlg.

Relevant ATLAS issue: https://its.cern.ch/jira/browse/ATR-22494 (thanks to @rbielski)

mentioned in issue #163 (closed)

added 1 commit

• e6b3006a - Property: Catch all parsing errors

Compare with previous version

added lhcb-gaudi-head label

• [2020-12-17 00:28] Validation started with lhcb-gaudi-head#2813
• [2020-12-17 01:09] Validation started with lhcb-run2-gaudi-head#42
• [2020-12-18 00:20] Validation started with lhcb-gaudi-head#2814
• [2020-12-19 00:18] Validation started with lhcb-gaudi-head#2815
• [2020-12-19 01:17] Validation started with lhcb-run2-gaudi-head#43
• [2020-12-20 00:36] Validation started with lhcb-run2-gaudi-head#44
• [2020-12-21 01:28] Validation started with lhcb-gaudi-head#2816
• [2020-12-21 02:03] Validation started with lhcb-gaudi-head#2816
• [2020-12-24 00:33] Validation started with lhcb-run2-gaudi-head#45
• [2020-12-28 01:27] Validation started with lhcb-gaudi-head#2817
• [2020-12-31 00:26] Validation started with lhcb-run2-gaudi-head#46
• [2021-01-04 01:25] Validation started with lhcb-gaudi-head#2818
• [2021-01-05 01:30] Validation started with lhcb-gaudi-head#2819
• [2021-01-06 00:18] Validation started with lhcb-gaudi-head#2820
• [2021-01-07 01:05] Validation started with lhcb-run2-gaudi-head#47
• [2021-01-07 02:42] Validation started with lhcb-gaudi-head#2821
• [2021-01-08 00:25] Validation started with lhcb-gaudi-head#2822
• [2021-01-09 00:35] Validation started with lhcb-gaudi-head#2823
• [2021-01-09 01:27] Validation started with lhcb-run2-gaudi-head#48
• [2021-01-09 09:37] Validation started with lhcb-gaudi-head#2823
• [2021-01-11 14:35] Validation started with lhcb-gaudi-head#2824

approved this merge request

merged

mentioned in commit 01c1071a