Allow returning void in a MergingTransformer
The current MergingTransformer signature cannot return void. This is fixing it and adding an alias MergingConsumer
for the case of void returning signature.
Also adds tests of the 2 cases.
Edited by Sebastien Ponce
Merge request reports
Activity
- Resolved by Sebastien Ponce
If it doesn't return anything, thus is
Many -> void
, wouldn't a better name beMergingConsumer
?
mentioned in merge request lhcb/LHCb!3001 (merged)
added 1 commit
- a0f1a4ac - Allow returning void in a Merging transformer
- [2021-04-14 12:12] Validation started with lhcb-master-mr#2194
added 1 commit
- 753022be - Introduced MergingConsumer alias in functional Algorithms
changed milestone to %v35r3
added lhcb-gaudi-head lhcb-lcg-dev4 labels
assigned to @clemenci
- Resolved by Marco Clemencic
@clemenci Maybe wait a bit more for this one. I'd like to understand why line !1199 (diffs) cannot be written without the namespace and the arguments for
MergingConsumer
. It's fishy
- Resolved by Sebastien Ponce
- [2021-04-15 17:29] Validation started with lhcb-master-mr#2208
- [2021-04-16 00:08] Validation started with lhcb-gaudi-head#2903
- [2021-04-16 00:36] Validation started with lhcb-lcg-dev4#1617
- [2021-04-16 00:56] Validation started with lhcb-run2-gaudi-head#111
- [2021-04-16 01:32] Validation started with lhcb-gaudi-head#2903
- [2021-04-16 09:19] Validation started with lhcb-master-mr#2211
- [2021-04-17 00:04] Validation started with lhcb-gaudi-head#2904
- [2021-04-17 00:33] Validation started with lhcb-lcg-dev4#1618
- [2021-04-17 01:02] Validation started with lhcb-run2-gaudi-head#112
- [2021-04-17 01:35] Validation started with lhcb-gaudi-head#2904
- [2021-04-18 00:03] Validation started with lhcb-gaudi-head#2905
- [2021-04-18 00:06] Validation started with lhcb-lcg-dev4#1619
- [2021-04-18 00:11] Validation started with lhcb-run2-gaudi-head#113
- [2021-04-19 00:04] Validation started with lhcb-gaudi-head#2906
- [2021-04-19 00:34] Validation started with lhcb-lcg-dev4#1620
- [2021-04-19 00:49] Validation started with lhcb-run2-gaudi-head#114
Edited by Software for LHCbadded 1 commit
- 606677b8 - Added an extra MergingTransformer constructor
Please register or sign in to reply