Added removeEntity interface to MonitoringHub

This allows to remove entities from the hub (and thus from the sinks in the back) and thus allows to use entities in temporary objects, and not only in Tool/algorithms.

The counter part is that BufferableCounters are no more movable, although I doubt anyone really want to move a counter. It only has the consequence that you can hardly have vectors of counters, but arrays or deques are still fine

mentioned in merge request lhcb/LHCb!3001 (merged)

mentioned in merge request lhcb/LHCb!3022 (merged)

added 1 commit

• 565d7b93 - Added removeEntity interface to MonitoringHub

Compare with previous version

I very much like that fact that the 'register' calls in constructors are now 'balanced' by 'unregister' calls in the destructor -- which also clarifies that the scope of entities is 'contained' in (i.e. a subset of) the lifetime of monitoring hub.

@clemenci Could this be merged so that we can merge some LHCb MRs waiting for it ?

changed milestone to %v36r0

assigned to @clemenci

added lhcb-gaudi-head label

• [2021-05-08 00:04] Validation started with lhcb-gaudi-head#2923
• [2021-05-08 01:06] Validation started with lhcb-run2-gaudi-head#125
• [2021-05-09 00:03] Validation started with lhcb-gaudi-head#2924
• [2021-05-09 00:20] Validation started with lhcb-run2-gaudi-head#126
• [2021-05-11 00:04] Validation started with lhcb-gaudi-head#2925
• [2021-05-12 00:06] Validation started with lhcb-gaudi-head#2926
• [2021-05-13 00:07] Validation started with lhcb-gaudi-head#2927
• [2021-05-14 00:41] Validation started with lhcb-run2-gaudi-head#127
• [2021-05-14 01:25] Validation started with lhcb-gaudi-head#2928
• [2021-05-15 00:04] Validation started with lhcb-gaudi-head#2929
• [2021-05-15 00:27] Validation started with lhcb-run2-gaudi-head#128
• [2021-05-15 00:41] Validation started with lhcb-gaudi-head#2929
• [2021-05-16 00:03] Validation started with lhcb-gaudi-head#2930
• [2021-05-18 00:04] Validation started with lhcb-gaudi-head#2931
• [2021-05-18 00:54] Validation started with lhcb-run2-gaudi-head#129
• [2021-05-19 00:04] Validation started with lhcb-gaudi-head#2932
• [2021-05-19 01:16] Validation started with lhcb-gaudi-head#2932
• [2021-05-20 00:10] Validation started with lhcb-gaudi-head#2933
• [2021-05-20 00:52] Validation started with lhcb-run2-gaudi-head#130

approved this merge request

@sponce, I'm merging this, but it breaks LHCb Online compilation with:

error: invalid new-expression of abstract class type 'OnlMonitorSink'

https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaudi-head/2933/Online/x86_64-centos7-gcc9-opt/build#Online/Gaucho_18

merged

mentioned in commit 0f349b6c

resolved all threads