Remove IJobOptionsSvc
Removing IJobOptionsSvc
from C++ code is easy and already done in downstream projects, but it's not that obvious for (Gaudi)Python code.
With these changes the tests are passing, but downstream projects might rely on the IJobOptionsSvc
related methods and classes. To be tested.
To support the removal of IJobOptionsSvc
I had to fix an issue in GaudiConfig2.semantics.ComponentSemantics
, as it did not allow namespaces in interfaces class names. The change is backward incompatible, but I believe the feature was never used in production code.
For simplicity, I based this on !1179 (merged), so we should rebase once it is merged.
Closes #140 (closed)
Merge request reports
Activity
changed milestone to %v36r0
- Resolved by Marco Clemencic
- Resolved by Frank Winklmeier
mentioned in issue #185
added lhcb-gaudi-head label
- [2021-06-09 15:46] Automatic merge failed in [lhcb-gaudi-head#2953](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaudi-head/2953/Gaudi/checkout
- [2021-06-10 00:05] Validation started with lhcb-gaudi-head#2954
- [2021-06-10 00:56] Validation started with lhcb-run2-gaudi-head#144
- [2021-06-11 00:05] Validation started with lhcb-gaudi-head#2955
- [2021-06-11 00:51] Validation started with lhcb-run2-gaudi-head#145
- [2021-06-11 07:32] Validation started with lhcb-gaudi-head#2956
- [2021-06-11 11:58] Validation started with lhcb-gaudi-head#2957
- [2021-06-12 00:04] Validation started with lhcb-gaudi-head#2958
- [2021-06-12 00:53] Validation started with lhcb-run2-gaudi-head#146
- [2021-06-12 01:22] Validation started with lhcb-gaudi-head#2958
- [2021-06-15 00:04] Validation started with lhcb-gaudi-head#2959
- [2021-06-16 00:04] Validation started with lhcb-gaudi-head#2960
- [2021-06-16 00:51] Validation started with lhcb-run2-gaudi-head#147
- [2021-06-17 00:06] Validation started with lhcb-gaudi-head#2961
- [2021-06-17 00:58] Validation started with lhcb-run2-gaudi-head#148
Edited by Software for LHCbadded 17 commits
-
bf52e972...5b00cdf3 - 9 commits from branch
gaudi:master
- 95895aad - Do not track "checked-ness" of StatusCode at run time
- a43f9414 - Remove use of StatusCodeSvc and of deprecated functions
- b4709eb4 - restore StatusCode::ignore() signature
- 9f4bac4a - Merge branch 'drop-statuscodesvc' into HEAD
- 94753d43 - Allow interfaces with namespaces in GaudiConfig2 ComponentSemantics
- d8811e2f - Removed IJobOptionsSvc from C++
- 2cca60d9 - Add readOptions to IOptionsSvc
- feb3fea8 - removing IJobOptionsSvc from Python
Toggle commit list-
bf52e972...5b00cdf3 - 9 commits from branch
- Resolved by Frank Winklmeier
Looks like this is breaking the
BootstrapHelper
:from Gaudi.Main import BootstrapHelper bsh = BootstrapHelper() Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/scratch/fwinkl/Gaudi/src/Gaudi/python/Gaudi/Main.py", line 135, in __init__ f = getattr(gkl, 'py_bootstrap_%s' % name) File "/cvmfs/sft.cern.ch/lcg/releases/Python/3.7.6-b96a9/x86_64-centos7-gcc8-opt/lib/python3.7/ctypes/__init__.py", l ine 377, in __getattr__ func = self.__getitem__(name) File "/cvmfs/sft.cern.ch/lcg/releases/Python/3.7.6-b96a9/x86_64-centos7-gcc8-opt/lib/python3.7/ctypes/__init__.py", l ine 382, in __getitem__ func = self._FuncPtr((name_or_ordinal, self)) AttributeError: /scratch/fwinkl/Gaudi/build/GaudiKernel/libGaudiKernel.so: undefined symbol: py_bootstrap_addPropertyToCatalogue
I suppose we need to expose the relevant interface from
IOptionsSvc
instead.Edited by Frank Winklmeier
added 1 commit
- 217700a0 - Replaced Python BootstrapHelper.addPropertyToCatalogue with setOption
mentioned in merge request !1039 (merged)
mentioned in merge request atlas/athena!44367 (closed)
mentioned in commit a94c5062