Skip to content
Snippets Groups Projects

Remove IJobOptionsSvc

Merged Marco Clemencic requested to merge clemenci/Gaudi:140-remove-IJobOptionsSvc into master

Removing IJobOptionsSvc from C++ code is easy and already done in downstream projects, but it's not that obvious for (Gaudi)Python code.

With these changes the tests are passing, but downstream projects might rely on the IJobOptionsSvc related methods and classes. To be tested.

To support the removal of IJobOptionsSvc I had to fix an issue in GaudiConfig2.semantics.ComponentSemantics, as it did not allow namespaces in interfaces class names. The change is backward incompatible, but I believe the feature was never used in production code.

For simplicity, I based this on !1179 (merged), so we should rebase once it is merged.

Closes #140 (closed)

Edited by Marco Clemencic

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marco Clemencic added 3 commits

    added 3 commits

    • 5440f7ec - Removed IJobOptionsSvc from C++
    • 541bd926 - Add readOptions to IOptionsSvc
    • bf52e972 - removing IJobOptionsSvc from Python

    Compare with previous version

  • Marco Clemencic resolved all threads

    resolved all threads

  • Marco Clemencic mentioned in issue #185

    mentioned in issue #185

  • Marco Clemencic marked this merge request as ready

    marked this merge request as ready

  • Edited by Software for LHCb
  • Marco Clemencic added 17 commits

    added 17 commits

    • bf52e972...5b00cdf3 - 9 commits from branch gaudi:master
    • 95895aad - Do not track "checked-ness" of StatusCode at run time
    • a43f9414 - Remove use of StatusCodeSvc and of deprecated functions
    • b4709eb4 - restore StatusCode::ignore() signature
    • 9f4bac4a - Merge branch 'drop-statuscodesvc' into HEAD
    • 94753d43 - Allow interfaces with namespaces in GaudiConfig2 ComponentSemantics
    • d8811e2f - Removed IJobOptionsSvc from C++
    • 2cca60d9 - Add readOptions to IOptionsSvc
    • feb3fea8 - removing IJobOptionsSvc from Python

    Compare with previous version

  • Marco Clemencic added 3 commits

    added 3 commits

    • 8db3cc09 - Removed IJobOptionsSvc from C++
    • 85c683ec - Add readOptions to IOptionsSvc
    • 572d2489 - removing IJobOptionsSvc from Python

    Compare with previous version

    • Resolved by Frank Winklmeier

      Looks like this is breaking the BootstrapHelper:

      from Gaudi.Main import BootstrapHelper
      bsh = BootstrapHelper()
      
      Traceback (most recent call last):
        File "<stdin>", line 1, in <module>
        File "/scratch/fwinkl/Gaudi/src/Gaudi/python/Gaudi/Main.py", line 135, in __init__
          f = getattr(gkl, 'py_bootstrap_%s' % name)
        File "/cvmfs/sft.cern.ch/lcg/releases/Python/3.7.6-b96a9/x86_64-centos7-gcc8-opt/lib/python3.7/ctypes/__init__.py", l
      ine 377, in __getattr__
          func = self.__getitem__(name)
        File "/cvmfs/sft.cern.ch/lcg/releases/Python/3.7.6-b96a9/x86_64-centos7-gcc8-opt/lib/python3.7/ctypes/__init__.py", l
      ine 382, in __getitem__
          func = self._FuncPtr((name_or_ordinal, self))
      AttributeError: /scratch/fwinkl/Gaudi/build/GaudiKernel/libGaudiKernel.so: undefined symbol: py_bootstrap_addPropertyToCatalogue

      I suppose we need to expose the relevant interface from IOptionsSvc instead.

      Edited by Frank Winklmeier
  • added 1 commit

    • 217700a0 - Replaced Python BootstrapHelper.addPropertyToCatalogue with setOption

    Compare with previous version

  • Marco Clemencic resolved all threads

    resolved all threads

  • Marco Clemencic mentioned in merge request !1039 (merged)

    mentioned in merge request !1039 (merged)

  • mentioned in merge request atlas/athena!44367 (closed)

  • Frank Winklmeier approved this merge request

    approved this merge request

  • Marco Clemencic mentioned in commit a94c5062

    mentioned in commit a94c5062

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading