Skip to content
Snippets Groups Projects

Improve unused options report from JobOptionsSvc

Merged Marco Clemencic requested to merge clemenci/Gaudi:improve-unused-properties-report into master
All threads resolved!

After !1179 (merged) we discovered issues in LHCb Run2 support branches as some jobs/tests are still configured with .opts files.

In principle we should have detected issues in properties names earlier, but somehow it didn't happen, so I decided to add something to help in detection of typos of property names.

This MR includes:

  • sorting of the JobOptionsSvc report of unused options
  • mark with the comment // unused the unused options in the JOBOPTSDUMPFILE
  • add a Python script (gaudi_list_opts_typos) that scans the new JOBOPTSDUMPFILE and prints possible typos in the names of the unused properties

To be noted that the options dump is generated at start so it might mark as unused options for configurables that are created during the event loop. Moreover the report of the script is not failure proof as it only checks the name of the property against options that have the same prefix (up to the last dot), but it should be enough to detect the mistakes that were accepted with the old JobOptionsSvc.

/cc @cattanem @rmatev @fwinkl

Edited by Marco Clemencic

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • c93ca63d - rename list_opts_typos to gaudi_list_opts_typos

    Compare with previous version

  • added 1 commit

    • f418257e - Usea argparse instead of click

    Compare with previous version

  • added 1 commit

    • a7d155c6 - Use argparse instead of click

    Compare with previous version

  • Marco Clemencic resolved all threads

    resolved all threads

  • Frank Winklmeier approved this merge request

    approved this merge request

  • Edited by Software for LHCb
  • Marco Clemencic changed the description

    changed the description

  • Marco Clemencic mentioned in commit 3b6fb2c5

    mentioned in commit 3b6fb2c5

  • Please register or sign in to reply
    Loading