Dropped (UN)LIKELY macro

This comes on top of !1307 (merged) and drops the definitions of the (UN)LIKELY macros. This MR is thus non backward compatible and supposes that all users have either cleaned up their code or defined the macro themselves. For the moment, this has the tag not for merge for this reason

added not for merge label

mentioned in merge request lhcb/LHCb!3113 (merged)

• [2021-06-23 12:56] Validation started with lhcb-master-mr#2505
• [2021-07-30 14:58] Validation started with lhcb-master-mr#2637
• [2021-08-02 09:07] Validation started with lhcb-master-mr#2647
• [2021-08-02 16:09] Validation started with lhcb-master-mr#2652
• [2023-07-19 00:03] Validation started with lhcb-gaudi-head#3630
• [2023-07-19 00:15] Validation started with lhcb-run2-gaudi-head#584
• [2023-07-19 07:06] Validation started with lhcb-gaudi-head#3631

marked this merge request as ready

changed title from Draft: Attempt to make LIKELY macro empty to Dropped (UN)LIKELY macro

changed the description

added code cleanup label

added 59 commits

• 37ca004c...b65f1d45 - 57 commits from branch master
• 8b64d964 - Dropped defineition of (UN)LIKELY macro
• d1d2cd2b - Dropped usage of (UN)LIKELY macro

Compare with previous version

added 2 commits

• 33b12c42 - Dropped usage of (UN)LIKELY macro
• ba30bf0f - Dropped defineition of (UN)LIKELY macro

Compare with previous version

added 139 commits

• ba30bf0f...83a1ddab - 137 commits from branch master
• 2847e641 - Dropped usage of (UN)LIKELY macro
• eb34ce37 - Dropped definition of (UN)LIKELY macro

Compare with previous version

@clemenci what do you think we should do with this one ? Maybe split it in 2 : the drop of the usage that we could merge and the removal of the definition that could wait longer and especially until we have C++20 and the [[likely]] feature ?

changed the description

resolved all threads

added 94 commits

• eb34ce37...3ef4ac76 - 92 commits from branch master
• 1fe7cc7d - Dropped usage of (UN)LIKELY macro
• 80932039 - Dropped definition of (UN)LIKELY macro

Compare with previous version

added 1 commit

• bf31a575 - Dropped definition of (UN)LIKELY macro

Compare with previous version

added 351 commits

• bf31a575...4784576d - 350 commits from branch master
• aff0dbfa - Dropped definition of (UN)LIKELY macro

Compare with previous version

@clemenci I've rebased this and I believe that we could consider merging now that 2 years have passed and no LIKELY is back in the code.

removed not for merge label

assigned to @clemenci

changed milestone to %v37r0