Skip to content
Snippets Groups Projects

Correctly group histograms in ROOT files

Merged Marco Clemencic requested to merge clemenci-master-patch-67730 into master
All threads resolved!

The previous version was using <component>/<hist_id> as histogram id in the ROOT file, but it is better to create a directory called <component> and store the object <hist_id> in it. If the histogram id contains /s, the corresponding directories are created too.

With !1234 (63917b20) histograms of tools are stored in subdirectories of the parent. For example, the histogram MyHist of the tool MyAlg.MyTool is stored in a ROOT file with the path MyAlg/MyTool/MyHist.

To-do:

  • add test
Edited by Marco Clemencic

Merge request reports

Pipeline #2862000 passed

Pipeline passed for 85b5c471 on clemenci-master-patch-67730

Merged by Marco ClemencicMarco Clemencic 3 years ago (Jul 26, 2021 3:13pm UTC)

Loading

Pipeline #2863152 passed

Pipeline passed for 1853543b on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sebastien Ponce approved this merge request

    approved this merge request

  • added 1 commit

    • 32a017ab - Refactor to move TDirectory management inside saveRootHistoInternal

    Compare with previous version

  • added 1 commit

    • 85b5c471 - User ranges::accumulate instead of a for loop

    Compare with previous version

  • Marco Clemencic resolved all threads

    resolved all threads

  • Sebastien Ponce approved this merge request

    approved this merge request

  • Sebastien Ponce resolved all threads

    resolved all threads

  • Marco Clemencic mentioned in commit 1853543b

    mentioned in commit 1853543b

  • Please register or sign in to reply
    Loading