"Fixed" scan_dict_deps.py for not including directories
This was discovered thanks to a name collision between Eigen and DD4hep, Eigen having an header file named "Core" (with no extension indeed) and DD4hep a directory with same name. DD4hep happened to come first in the dependency list and thus the directort was used...
Note that this reveal a deeper problem in the scanning made by this tool : no scoping and thus no cleaning of the list of directories when going to next file. This is the actual root of the problem that lead to DD4hep being first in the dependency list
Merge request reports
Activity
added bug fix label
assigned to @clemenci
changed milestone to %v36r1
added lhcb-gaudi-head label
Thanks for the fix.
Actually it's not really a matter of order. I guess that without DD4hep in the search path I did not find
Core
, so I was silently ignoring it (this is to be able to work with generated headers that are not there yet or with headers that are not really included because ofifdef
s). With DD4hep I findCore
and try to open it even if it is a directory.- [2021-09-03 00:06] Validation started with lhcb-gaudi-head#3025
- [2021-09-03 00:56] Validation started with lhcb-run2-gaudi-head#188
Edited by Software for LHCbmentioned in commit 44d4d19c