Update Entity to expose mergeAndReset method of internal object

MR adds a mergeAndReset(Entity) method to Monitoring::Hub::Entity to simplify the aggregation of Accumulators.

No protection is offered against use with incompatible entities. I discussed this with @sponce but we agreed that the additional overhead for the expected use case (essentially just the summing of two integers where compatibility is already guaranteed by the calling class) would be excessive. A comment was added to warn the users that they must ensure compatibility themselves before calling.

mentioned in merge request lhcb/Allen!641 (closed)

changed milestone to %v36r1

assigned to @clemenci

added lhcb-gaudi-head label

• [2021-09-18 00:04] Validation started with lhcb-gaudi-head#3039
• [2021-09-18 00:46] Validation started with lhcb-run2-gaudi-head#196
• [2021-09-19 00:03] Validation started with lhcb-gaudi-head#3040
• [2021-09-19 00:28] Validation started with lhcb-run2-gaudi-head#197
• [2021-09-20 00:03] Validation started with lhcb-gaudi-head#3041
• [2021-09-21 00:04] Validation started with lhcb-gaudi-head#3042
• [2021-09-21 00:41] Validation started with lhcb-run2-gaudi-head#198
• [2021-09-22 00:03] Validation started with lhcb-gaudi-head#3043
• [2021-09-22 00:48] Validation started with lhcb-run2-gaudi-head#199
• [2021-09-23 00:04] Validation started with lhcb-gaudi-head#3044
• [2021-09-24 00:04] Validation started with lhcb-gaudi-head#3045
• [2021-09-24 00:52] Validation started with lhcb-run2-gaudi-head#200
• [2021-09-25 00:04] Validation started with lhcb-gaudi-head#3046
• [2021-09-26 00:03] Validation started with lhcb-gaudi-head#3047
• [2021-09-27 00:04] Validation started with lhcb-gaudi-head#3048
• [2021-09-28 00:04] Validation started with lhcb-gaudi-head#3049
• [2021-09-29 00:04] Validation started with lhcb-gaudi-head#3050
• [2021-09-30 00:04] Validation started with lhcb-gaudi-head#3051
• [2021-09-30 00:45] Validation started with lhcb-run2-gaudi-head#201
• [2021-10-01 00:07] Validation started with lhcb-gaudi-head#3052
• [2021-10-01 00:58] Validation started with lhcb-run2-gaudi-head#202
• [2021-10-02 00:04] Validation started with lhcb-gaudi-head#3053
• [2021-10-03 00:03] Validation started with lhcb-gaudi-head#3054
• [2021-10-04 00:03] Validation started with lhcb-gaudi-head#3055
• [2021-10-05 11:32] Validation started with lhcb-gaudi-head#3056
• [2021-10-06 00:04] Validation started with lhcb-gaudi-head#3057
• [2021-10-06 00:40] Validation started with lhcb-run2-gaudi-head#204
• [2021-10-07 00:16] Validation started with lhcb-gaudi-head#3058
• [2021-10-08 00:03] Validation started with lhcb-gaudi-head#3059
• [2021-10-09 00:11] Validation started with lhcb-run2-gaudi-head#207
• [2021-10-10 00:03] Validation started with lhcb-gaudi-head#3061
• [2021-10-10 00:06] Validation started with lhcb-run2-gaudi-head#208
• [2021-10-11 00:05] Validation started with lhcb-gaudi-head#3062
• [2021-10-12 00:08] Validation started with lhcb-gaudi-head#3063
• [2021-10-12 01:00] Validation started with lhcb-run2-gaudi-head#209
• [2021-10-12 11:46] Validation started with lhcb-gaudi-head#3064
• [2021-10-13 00:06] Validation started with lhcb-gaudi-head#3065

approved this merge request

mentioned in merge request !1257 (merged)

changed milestone to %v36r2

added 1 commit

• 0b362f5a - Add type check to Entity::mergeAndReset

Compare with previous version

added 1 commit

• 208600b2 - revert previous commit

Compare with previous version

Hi @clemenci unfortunately this doesn't work because in the vast majority of cases the Entity is created when MonitoringHub::registerEntity is called from the constructor of the base class BufferableCounter - so many incompatible Entity objects will share an identical typeindex. Additionally, the Entity created when a Counter is constructed will not match the typeindex of an Entity created from exactly the same Counter after the fact (when the derived class has finished being constructed).

• [2021-10-14 00:05] Validation started with lhcb-gaudi-head#3066
• [2021-10-14 00:35] Validation started with lhcb-run2-gaudi-head#210
• [2021-10-15 00:06] Validation started with lhcb-gaudi-head#3067

mentioned in issue #207 (closed)

resolved all threads

approved this merge request

mentioned in commit db8604d1

merged

mentioned in issue lhcb/Moore#448 (closed)

mentioned in issue lhcb/Moore#449 (closed)