Fix bug in bin indexing for >1D Histograms

Fixes an error in the determination of Histogram bin indices for non-square >1D histograms. The size of axis N-1 was used in the calculation when the size of axis N should have been used. For 2D histograms with more bins in x than y, e.g. the ECAL segmentation, this was causing a buffer overflow.

This fix is needed for next week's beam test as the monitoring planned for Allen includes ECAL histograms.

mentioned in merge request lhcb/Allen!641 (closed)

assigned to @clemenci

added lhcb-gaudi-head label

changed milestone to %v36r2

It would be nice to have a test exposing the problem and validating the solution.

added 1 commit

• 03df95ee - Add unit test for 2D histograms with fewer bins in y than in x

Compare with previous version

added 1 commit

• ec2f373e - Fix typo in test

Compare with previous version

• [2021-10-18 00:05] Validation started with lhcb-gaudi-head#3069
• [2021-10-18 00:36] Validation started with lhcb-run2-gaudi-head#212
• [2021-10-18 08:24] Validation started with lhcb-gaudi-head#3070

resolved all threads

approved this merge request

merged

mentioned in commit 2b77e11c

mentioned in issue lhcb/Moore#448 (closed)

mentioned in issue lhcb/Moore#449 (closed)

mentioned in issue lhcb/Moore#454 (closed)