Skip to content
Snippets Groups Projects

THistSvc: cache TObject types

Merged Frank Winklmeier requested to merge fwinkl/Gaudi:thistsvc_types into master
All threads resolved!

The TObject::InheritsFrom call can be quite slow. Since we already deduce the object type (TH1, TTree, etc.) during registration, save this information and use it instead of re-deriving it every time. Also avoid calling updateFiles if no TTrees are registered.

Both these changes significantly speed up the EndEvent incident handling for jobs with large (>10k) number of histograms. Thanks to @rbielski for reporting this.

Also re-organize struct THistID to avoid padding (using Pahole), delete unused reset method and include debug message protections from @smh (!1283 (closed)).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 8510618c - THistSvc: cache TObject types

    Compare with previous version

  • added 1 commit

    • e2fd09f1 - THistSvc: cache TObject types

    Compare with previous version

  • added 1 commit

    • d9ddd8c9 - THistSvc: cache TObject types

    Compare with previous version

  • Frank Winklmeier resolved all threads

    resolved all threads

  • Marco Clemencic approved this merge request

    approved this merge request

  • Marco Clemencic mentioned in commit 81ceb46b

    mentioned in commit 81ceb46b

  • Please register or sign in to reply
    Loading